Insignificant destructors rfc 2229#84152
Merged
bors merged 1 commit intorust-lang:masterfrom May 15, 2021
Merged
Conversation
Contributor
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
r? @ghost |
Contributor
Author
|
Testing with CI. Local build kept ommitting |
jyn514
added
the
T-compiler
crlf0710
added
S-experimental
Member
|
Triage: switching to S-experimental since reviewer=ghost. |
null-sleep
force-pushed
the
insignificant_dtor
branch
from
532ebb9 to
eb794ce
Compare
This comment has been minimized.
This comment has been minimized.
null-sleep
force-pushed
the
insignificant_dtor
branch
2 times, most recently
from
5a39524 to
f37ed61
Compare
arora-aman
reviewed
May 4, 2021
src/test/ui/closures/2229_closure_analysis/migrations/insignificant_drop_attr_migrations.fixed
Outdated
Show resolved
Hide resolved
src/test/ui/closures/2229_closure_analysis/migrations/insignificant_drop_attr_no_migrations.rs
Outdated
Show resolved
Hide resolved
src/test/ui/closures/2229_closure_analysis/migrations/insignificant_drop_attr_migrations.rs
Outdated
Show resolved
Hide resolved
null-sleep
changed the title
null-sleep
force-pushed
the
insignificant_dtor
branch
from
f37ed61 to
2d12033
Compare
Contributor
Author
nikomatsakis
requested changes
May 5, 2021
Collaborator
|
☔ The latest upstream changes (presumably #84982) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
null-sleep
force-pushed
the
insignificant_dtor
branch
from
2d12033 to
9a0a8aa
Compare
nikomatsakis
requested changes
May 10, 2021
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Looks great! A few more nits.
Collaborator
|
☔ The latest upstream changes (presumably #84730) made this pull request unmergeable. Please resolve the merge conflicts. |
…type has a significant drop
null-sleep
force-pushed
the
insignificant_dtor
branch
from
9a0a8aa to
a7e1cec
Compare
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit a7e1cec has been approved by |
bors
removed
the
S-waiting-on-author
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
crlf0710
removed
the
S-experimental
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustc_insignificant_dtorto annotate the drop method.A type marked with the attribute
rustc_insignificant_dtoris considered to not be significant. A drop is significant if it is implemented by the user or does anything that will have any observable behavior (other than freeing up memory).rust-lang/project-rfc-2229#35