rustdoc: Remove double toggle to show undocumented items

[Swatinem]

This removes an indirection, having to expand a trait impl first, just to have another toggle inside.

TBH, the toggles code in rustdoc is super hard to understand.

Before:

After:

[rust-highfive]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

[rust-highfive]

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

[jyn514]

@Swatinem this was changed as part of #54162 I think, in response to #55900. Can you build the Iterator docs locally and see how long they take to load compared the existing page? You can do that with x.py doc --stage 1 library/std, then opening build/x86_64-unknown-linux-gnu/doc/std/iter/trait.Iterator.html in a browser (or replace x86_64... if you're developing on a different platform)

[GuillaumeGomez]

@jyn514 x.py doc std --stage 1 works too. ;)

Also: we should add a --open option like cargo for such cases. What do you think about that?

[jyn514]

Sure, seems useful.

[GuillaumeGomez]

Ok, gonna add that then.

[bors]

☔ The latest upstream changes (presumably #84754) made this pull request unmergeable. Please resolve the merge conflicts.

[jyn514]

@Swatinem in your screenshot, ToOwned still has the "show hidden undocumented items" toggle - is that intentional?

[Swatinem]

ToOwned still has the "show hidden undocumented items" toggle - is that intentional?

Yes, as that has visible-by-default items, vs the other example that only had hidden-by-default items.

TBH, I’m not sure I want to continue with this patch as its a giant hack, and since other people are touching the toggles anyway, someone probably has a much better solution.