Add std::os::unix::fs::chroot to change the root directory of the current process by joshtriplett · Pull Request #84716 · rust-lang/rust

joshtriplett · 2021-04-29T20:51:12Z

This is a straightforward wrapper that uses the existing helpers for C
string handling and errno handling.

Having this available is convenient for UNIX utility programs written in
Rust, and avoids having to call the unsafe libc::chroot directly and
handle errors manually, in a program that may otherwise be entirely safe
code.

rust-highfive · 2021-04-29T20:51:15Z

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

dtolnay

Seems good to me! :)

dtolnay · 2021-04-29T21:05:33Z

@bors r+

bors · 2021-04-29T21:05:34Z

📌 Commit 2fb2f0b has been approved by dtolnay

Add std::os::unix::fs::chroot to change the root directory of the current process This is a straightforward wrapper that uses the existing helpers for C string handling and errno handling. Having this available is convenient for UNIX utility programs written in Rust, and avoids having to call the unsafe `libc::chroot` directly and handle errors manually, in a program that may otherwise be entirely safe code.

jackh726 · 2021-04-29T21:31:17Z

Failed in #84718

@bors r-

joshtriplett · 2021-04-29T21:45:20Z

Fixed the doc link.

@bors r=dtolnay rollup

bors · 2021-04-29T21:45:21Z

📌 Commit 3b414c3 has been approved by dtolnay

dtolnay · 2021-04-29T21:46:59Z

library/std/src/sys/unix/ext/fs.rs

+/// This typically requires privileges, such as root or a specific capability.
+///
+/// This does not change the current working directory; you should call
+/// [`std::env::set_current_dir`][`crate::env::set_current_dir`] afterwards.


Adding extern crate self as std; in std's lib.rs would avoid having to do the link target explicitly here (and definitely elsewhere too).

According to @jyn514, doing that currently produces an ICE.

This is #73445. I haven't tried it in a while, it may work now.

Also, you can shorten a bit like so:

Suggested change

/// [`std::env::set_current_dir`][`crate::env::set_current_dir`] afterwards.

/// [`std::env::set_current_dir`](crate::env::set_current_dir) afterwards.

If you go the extern crate route, you might want to do

#[cfg(doc)] extern crate self as std;

to ensure it's only used for docs.

@camelid that will break any links that are re-exported, cfg(doc) isn't set for dependencies.

I haven't tried it in a while, it may work now.

Just tried it, extern crate self as core works but not extern crate self as std (#84755, #73445 (comment)).

Add std::os::unix::fs::chroot to change the root directory of the current process This is a straightforward wrapper that uses the existing helpers for C string handling and errno handling. Having this available is convenient for UNIX utility programs written in Rust, and avoids having to call the unsafe `libc::chroot` directly and handle errors manually, in a program that may otherwise be entirely safe code.

bors · 2021-04-30T05:37:26Z

⌛ Testing commit eda658dc7c95c69e8c1f7191b0ba7bebb6e6be2e with merge fe71c7f6e0f60886eff3b39268916552115b74e1...

bors · 2021-04-30T05:57:51Z

💔 Test failed - checks-actions

joshtriplett · 2021-04-30T06:17:15Z

Well, that's interesting. Either Fuchsia doesn't have chroot, or libc isn't providing a binding to it. I'll investigate.

cc @tmandry for Fuchsia.

joshtriplett · 2021-04-30T06:37:21Z

The answer appears to be that Fuchsia doesn't have chroot. I'll add a cfg.

…rent process This is a straightforward wrapper that uses the existing helpers for C string handling and errno handling. Having this available is convenient for UNIX utility programs written in Rust, and avoids having to call the unsafe `libc::chroot` directly and handle errors manually, in a program that may otherwise be entirely safe code.

joshtriplett · 2021-04-30T07:11:44Z

@bors try

bors · 2021-04-30T07:11:53Z

⌛ Trying commit ffb874a with merge 7ede84235ed7c851bb5bc27e1f7d6f438d6b78d5...

bors · 2021-04-30T08:01:46Z

☀️ Try build successful - checks-actions
Build commit: 7ede84235ed7c851bb5bc27e1f7d6f438d6b78d5 (7ede84235ed7c851bb5bc27e1f7d6f438d6b78d5)

joshtriplett · 2021-04-30T11:24:54Z

@bors r=dtolnay rollup=never

bors · 2021-04-30T11:24:55Z

📌 Commit ffb874a has been approved by dtolnay

bors · 2021-04-30T12:19:41Z

⌛ Testing commit ffb874a with merge 7506228...

bors · 2021-04-30T14:39:21Z

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 7506228 to master...

Fix `vxworks` Some PRs made the `vxworks` target not build anymore. This PR fixes that: - rust-lang#82973: copy `ExitStatusError` implementation from `unix`. - rust-lang#84716: no `libc::chroot` available on `vxworks`, so for now don't implement `os::unix::fs::chroot`.

rust-highfive assigned m-ou-se Apr 29, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021

joshtriplett mentioned this pull request Apr 29, 2021

Tracking Issue for feature(unix_chroot) #84715

Closed

3 tasks

joshtriplett added O-unix Operating system: Unix-like T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. Libs-Small Libs issues that are considered "small" or self-contained labels Apr 29, 2021

dtolnay approved these changes Apr 29, 2021

View reviewed changes

dtolnay assigned dtolnay and unassigned m-ou-se Apr 29, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2021

This comment has been minimized.

Sign in to view

jackh726 mentioned this pull request Apr 29, 2021

Rollup of 11 pull requests #84718

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 29, 2021

joshtriplett force-pushed the chroot branch from 2fb2f0b to 3b414c3 Compare April 29, 2021 21:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 29, 2021

dtolnay reviewed Apr 29, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

jackh726 mentioned this pull request Apr 29, 2021

Rollup of 11 pull requests #84726

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 30, 2021

joshtriplett force-pushed the chroot branch from eda658d to ffb874a Compare April 30, 2021 07:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 30, 2021

bors merged commit 7506228 into rust-lang:master Apr 30, 2021

rustbot added this to the 1.53.0 milestone Apr 30, 2021

bors mentioned this pull request Apr 30, 2021

Move all sys::ext modules to os #84200

Merged

joshtriplett deleted the chroot branch April 30, 2021 22:09

anp mentioned this pull request May 4, 2021

Fuchsia's target_family should be None, not "unix" #58590

Open

CDirkx mentioned this pull request May 19, 2021

Fix vxworks #85490

Merged

	/// [`std::env::set_current_dir`][`crate::env::set_current_dir`] afterwards.
	/// [`std::env::set_current_dir`](crate::env::set_current_dir) afterwards.

Uh oh!

Conversation

joshtriplett commented Apr 29, 2021

Uh oh!

rust-highfive commented Apr 29, 2021

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Apr 29, 2021

Uh oh!

bors commented Apr 29, 2021

Uh oh!

This comment has been minimized.

jackh726 commented Apr 29, 2021

Uh oh!

joshtriplett commented Apr 29, 2021

Uh oh!

bors commented Apr 29, 2021

Uh oh!

dtolnay Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

joshtriplett Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

jyn514 Apr 29, 2021

Choose a reason for hiding this comment

Uh oh!

camelid Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

camelid Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

jyn514 Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

jyn514 Apr 30, 2021

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

bors commented Apr 30, 2021

Uh oh!

This comment has been minimized.

bors commented Apr 30, 2021

Uh oh!

joshtriplett commented Apr 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshtriplett commented Apr 30, 2021

Uh oh!

joshtriplett commented Apr 30, 2021

Uh oh!

bors commented Apr 30, 2021

Uh oh!

bors commented Apr 30, 2021

Uh oh!

joshtriplett commented Apr 30, 2021

Uh oh!

bors commented Apr 30, 2021

Uh oh!

bors commented Apr 30, 2021

Uh oh!

bors commented Apr 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

joshtriplett commented Apr 30, 2021 •

edited

Loading