[beta] remove assert_matches#84759
Closed
Mark-Simulacrum wants to merge 4 commits intorust-lang:betafrom
Closed
Conversation
Contributor
|
rust-highfive
added
the
S-waiting-on-review
m-ou-se
approved these changes
Apr 30, 2021
Member
m-ou-se
left a comment
m-ou-se
left a comment
There was a problem hiding this comment.
Looks good to me. Only tiny downside is that those assert!()s will not display the Some(..) value if they very unexpectedly fail.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors r=m-ou-se rollup=never |
Collaborator
|
📌 Commit c87547e has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit c87547e with merge 662d20af9b7e7f590e6b9811ce77637b3baee91b... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
bors
added
S-waiting-on-bors
Member
Author
|
Closing in favor of #84864 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2021
…imulacrum [stable] 1.52.0 release This includes the release notes (rust-lang#84183) as well as cherry-picked commits from: * [beta] revert PR rust-lang#77885 rust-lang#84710 * [beta] remove assert_matches rust-lang#84759 * Revert PR 81473 to resolve (on beta) issues 81626 and 81658. rust-lang#83171 * [beta] rustdoc revert deref recur rust-lang#84868 * Fix ICE of for-loop mut borrowck where no suggestions are available rust-lang#83401 Additionally in "fresh work" we're also: * reverting: directly expose copy and copy_nonoverlapping intrinsics rust-lang#81238 to avoid rust-lang#84297 on 1.52
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2021
…crum [beta] Prepare beta 1.53.0 Along with updating the channel and updating the bootstrap compiler, this also includes: * 692454d - Fixes the diagnostics difference we had for some cycles already * 9157430 - Disables the known broken RLS builder on AArch64 Windows * rust-lang#84183 - Update RELEASES.md for 1.52.0 * rust-lang#84950 - Revert PR 83866 * rust-lang#84886 - Update RLS and Rustfmt Changes we backported to 1.52.0 that we also need to include in 1.53.0 to avoid regressing: * rust-lang#84867 - rustdoc: revert deref recur to resume inclusion of impl ExtTrait<Local> for ExtType * rust-lang#84759 - [beta] remove assert_matches * rust-lang#83171 - Revert PR 81473 to resolve (on beta) issues 81626 and 81658. r? `@ghost`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the assert_matches PR (#82770) on beta, to avoid #82913. It does not fix that issue, since it'll be a problem again in the next cycle (this PR targets beta only).
r? @m-ou-se