[experiment] Eagerly expand cfg and cfg_attr in all attribute inputs#85073
[experiment] Eagerly expand cfg and cfg_attr in all attribute inputs#85073petrochenkov wants to merge 3 commits intorust-lang:masterfrom
Conversation
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit a8c7b2a2d1480c233f0d66484d4a0ddc4354bde8 with merge b20a093d9fb1ffaa04ae9852cb034864a992bafd... |
|
☀️ Try build successful - checks-actions |
|
Queued b20a093d9fb1ffaa04ae9852cb034864a992bafd with parent 50e1dc1, future comparison URL. |
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
Finished benchmarking try commit (b20a093d9fb1ffaa04ae9852cb034864a992bafd): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
|
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
🎉 Experiment
|
|
Three root regressions:
|
|
So, my conclusion is that it's a viable strategy, from both performance and compatibility point of view. |
Based on #84995.
r? @Aaron1011