Merged
Conversation
Contributor
|
rust-highfive
added
the
S-waiting-on-review
Member
|
I had some similar questions about rustfmt after I checked the toolstate page earlier (admittedly a bit prematurely) and noticed that it hadn't been updated in a while either. Not sure if that's expected or related, but sharing in case it is |
Member
What is toolstate upgrade? |
Contributor
Author
|
I meant "Toolstate changed!" notifications such as #84886 (comment) |
Contributor
Author
|
I guess there's no harm in pushing this further and I believe chances of this needing a follow-up are slim @bors r+ p=1 |
Collaborator
|
📌 Commit 9235446 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
May 17, 2021
Tested on commit rust-lang/rust@fa72878. Direct link to PR: <rust-lang/rust#85352> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains rust-lang/rls#1736. With #82208 merged, this should now close #85225. Tested locally with
./x.py test src/tools/rlsand seems to be working as expected.I noticed the rustfmt merge didn't trigger toolstate upgrade (because we pruned most but not all of the related machinery?), so I'd rather get this rubber-stamped by someone more knowledgeable with infra/the merged changes in case I missed something and need to include something else here to unbreak the RLS toolstate.
r? @Mark-Simulacrum