Skip to content

Support pretty printing slices using GDB#85363

Merged
bors merged 3 commits intorust-lang:masterfrom
EFanZh:gdb-pretty-print-slices
Jul 8, 2021
Merged

Support pretty printing slices using GDB#85363
bors merged 3 commits intorust-lang:masterfrom
EFanZh:gdb-pretty-print-slices

Conversation

@EFanZh
Copy link
Contributor

@EFanZh EFanZh commented May 16, 2021 •
edited
Loading

Support pretty printing &[T], &mut [T] and &mut str types using GDB.

Support pretty printing &mut [T] and &mut str types using LLDB.

Fixes #85219.

@rust-highfive
Copy link
Contributor

rust-highfive commented May 16, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2021
@EFanZh EFanZh force-pushed the gdb-pretty-print-slices branch from f5721c0 to 1aa6307 Compare May 18, 2021 14:26
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented May 26, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 26, 2021

📌 Commit 1aa6307 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 26, 2021
@JohnTitor
Rollup merge of rust-lang#85363 - EFanZh:gdb-pretty-print-slices, r=M…
5221548 
…ark-Simulacrum

Support pretty printing slices using GDB

Support pretty printing `&[T]`, `&mut [T]` and `&mut str` types using GDB.

Support pretty printing `&mut [T]` and `&mut str` types using LLDB.

Fixes rust-lang#85219.
@JohnTitor JohnTitor mentioned this pull request May 26, 2021
Closed
@JohnTitor
Copy link
Member

JohnTitor commented May 26, 2021

Failed on rollup: #85705 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2021
@EFanZh EFanZh force-pushed the gdb-pretty-print-slices branch from 1aa6307 to d5b48f0 Compare May 29, 2021 13:42
@Aaron1011
Copy link
Contributor

Aaron1011 commented Jun 4, 2021

@EFanZh Is this now ready to merge again?

@EFanZh
Copy link
Contributor Author

EFanZh commented Jun 5, 2021

@Aaron1011 I have fixed the test failure, but I am not very confident about my change. I think someone who is familiar with GDB and LLDB pretty printing should review this before merging it.

@JohnCSimon
Copy link
Member

JohnCSimon commented Jun 20, 2021

@rustbot label: +S-waiting-on-review -S-waiting-on-author

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 20, 2021
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 20, 2021

r? @michaelwoerister -- I'd like a second opinion before r+'ing this, it seems like it's OK but I'm not very familiar with the details here.

@michaelwoerister
Copy link
Member

michaelwoerister commented Jun 30, 2021

Thanks for the PR, @EFanZh! I'll take a look shortly.

michaelwoerister
michaelwoerister reviewed Jul 1, 2021
View reviewed changes
michaelwoerister
michaelwoerister reviewed Jul 1, 2021
View reviewed changes
@EFanZh EFanZh force-pushed the gdb-pretty-print-slices branch from d5b48f0 to 0112b90 Compare July 3, 2021 15:42
@michaelwoerister
Copy link
Member

michaelwoerister commented Jul 5, 2021

Thanks, @EFanZh!

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 5, 2021

📌 Commit 0112b90 has been approved by michaelwoerister

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 5, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 5, 2021
@EFanZh
Copy link
Contributor Author

EFanZh commented Jul 6, 2021

I am not sure why pretty-printing does not work on Android target. @michaelwoerister Do you know how to fix this error?

@michaelwoerister
Copy link
Member

michaelwoerister commented Jul 7, 2021

All the other pretty printer tests seem to ignore android. I think it's fine to do that for pretty-slices.rs too for now. You can achieve that by adding the line // ignore-android: FIXME(#10381) as the first line of the file.

@michaelwoerister
Copy link
Member

michaelwoerister commented Jul 7, 2021

Thanks, @EFanZh! Let's give it another try: @bors r+

@bors
Copy link
Collaborator

bors commented Jul 7, 2021

📌 Commit 2b2bcf1 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2021
@bors
Copy link
Collaborator

bors commented Jul 7, 2021

⌛ Testing commit 2b2bcf1 with merge 76edd248b0850b0111bc736764e25877568a8ad2...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jul 7, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2021
@EFanZh
Copy link
Contributor Author

EFanZh commented Jul 7, 2021

The i686-mingw-1 test has failed. I ignored the tests on Windows like some other pretty printing tests. @michaelwoerister Is this OK with you?

@EFanZh EFanZh force-pushed the gdb-pretty-print-slices branch from 13c8598 to 1b0998c Compare July 7, 2021 17:05
@michaelwoerister
Copy link
Member

michaelwoerister commented Jul 8, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 8, 2021

📌 Commit 1b0998c has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2021
@bors
Copy link
Collaborator

bors commented Jul 8, 2021

⌛ Testing commit 1b0998c with merge 0deb536...

@bors
Copy link
Collaborator

bors commented Jul 8, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing 0deb536 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2021
@bors bors merged commit 0deb536 into rust-lang:master Jul 8, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 8, 2021
@EFanZh EFanZh deleted the gdb-pretty-print-slices branch September 11, 2021 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michaelwoerister michaelwoerister michaelwoerister left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@michaelwoerister michaelwoerister

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

Add gdb pretty printers for slices types (&[T] and &mut [T]).

10 participants

@EFanZh @rust-highfive @Mark-Simulacrum @bors @JohnTitor @Aaron1011 @JohnCSimon @michaelwoerister @rust-log-analyzer @rustbot