native lib: defer the duplicate check after relevant_lib check.

[12101111]

#84794 break code using conditional-compilation with #[link] attributes.

#[cfg(target_env = "musl")]
cfg_if::cfg_if! {
    if #[cfg(any(target_feature = "crt-static", feature = "llvm-libunwind"))] {
        #[link(name = "unwind", kind = "static", modifiers = "-bundle")]
        extern "C" {}
    } else {
        #[link(name = "unwind", cfg(feature = "system-llvm-libunwind"))]
        #[link(name = "gcc_s", cfg(not(feature = "system-llvm-libunwind")))]
        extern "C" {}
    }
}

[rust-highfive]

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

[petrochenkov]

r? @petrochenkov

[petrochenkov]

I don't know how I missed this, I remember specifically considering this case.
Looks like I've seen that we are already going through relevant_libs only in fn add_local_native_libraries, and didn't notice that it's not the case in fn add_upstream_native_libraries.

[petrochenkov]

This change is not strictly necessary for the fix, but let's leave it for consistency.
It also improves deduplication in the (unlikely) case of #[link(name = "foo")] #[link(wasm_import_module = "...")] #[link(name = "foo")].

[petrochenkov]

Could you add a test for this?
Preferably a UI test with -Z print-link-args (possibly with // normalize-stdout-test), or something like src/test/run-make-fulldeps/link-args-order if the former doesn't work out.

[12101111]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[petrochenkov]

@bors r+

[bors]

📌 Commit 8e42fa5 has been approved by petrochenkov

[bors]

⌛ Testing commit 8e42fa5 with merge f64503e...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing f64503e to master...