Merged
Conversation
This reverts commit 37a5b51.
This disables incremental (i.e., -Cincremental) taking effect unless an environment variable, RUSTC_FORCE_INCREMENTAL, is set to 1 in the environment of the running rustc. Currently incremental causes errors for many users, and we do not have an expectation of being able to quickly fix these errors in a backportable way - so, for now, disable incremental entirely. The user can still opt-in, but this way the majority of users merely get slower builds, not broken builds.
This won't enable incremental if -Cincremental is not already passed, but is seemingly necessary in the presence of -Zincremental-verify-ich which does not check for incremental being enabled before accessing incremental data structures, leading to an ICE.
Contributor
|
rust-highfive
added
the
S-waiting-on-review
This reverts commit 448d076 to address issue 85713 on beta.
This was referenced Jun 14, 2021
Member
Author
|
@bors r+ rollup=never p=100 |
Collaborator
|
📌 Commit 196e185 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a backport of:
And includes patches to:
#[repr(align)]with no argument toalignleads to ICE on Nightly/Beta. #85713 on beta.r? @Mark-Simulacrum