Implement Mutation- and BorrowOfLayoutConstrainedField in thir-unsafeck#86665
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Thanks for your help on this! I'll assign this to you in the tracking issue, if you want to implement something else in the future feel free to just drop a comment on the tracking issue, just to make sure that there aren't two people working on the same thing. With that said, the last few unsafe ops to implement are the trickiest, so having multiple eyes on them is a good thing. I don't have time to do a proper review today, but I think I can already tell that this PR doesn't cover references that arise from patterns (e.g. Also cc @nikomatsakis, if you want to take a look at this as well |
|
Thanks for your quick response! I have added some code (and a test case) now that deals with by-reference bindings in |
|
The title of this PR confused me, but you probably didn't mean thir-borrowck :p |
FabianWolff
changed the title
Fixed, thanks for catching this! Thinking about all the different borrow kinds etc. apparently got me confused... |
LeSeulArtichaut
left a comment
LeSeulArtichaut
left a comment
There was a problem hiding this comment.
Okay, sorry for the wait, here's a first review. This is certainly trickier than it looks, and I worry that we'll miss edge cases, but it's OK if we miss things in this PR because THIR unsafeck is gated under an explicitely-marked-as-unsound-do-not-enable option.
|
cc @nikomatsakis you might be interested in reviewing if you have enough bandwidth |
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
c80ed9d to
fbed40f
Compare
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
fbed40f to
a4066a3
Compare
LeSeulArtichaut
left a comment
LeSeulArtichaut
left a comment
There was a problem hiding this comment.
Okay, besides my last comment I haven't found a case where the implementation is wrong. I'll still pass this to someone with better knowledge of the language than me. In the meantime here are a few nits.
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
a4066a3 to
c269774
Compare
|
All done, thanks again for your comments! |
|
r? @oli-obk |
|
☔ The latest upstream changes (presumably #85263) made this pull request unmergeable. Please resolve the merge conflicts. |
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
c269774 to
0994dd7
Compare
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
0994dd7 to
e244b17
Compare
FabianWolff
force-pushed
the
layout-field-thir-unsafeck
branch
from
e244b17 to
b088861
Compare
|
@bors r+ |
|
📌 Commit b088861 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
7 participants
Since nobody has so far claimed Mutation- and BorrowOfLayoutConstrainedField in rust-lang/project-thir-unsafeck#7, I have taken the liberty of implementing them in thir-unsafeck.
r? @LeSeulArtichaut