Lint missing Abi in ast validation instead of lowering.#87114
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 2, 2021
Merged
Lint missing Abi in ast validation instead of lowering.#87114bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
|
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Jul 30, 2021
Comment on lines
+883
to
+905
| // FIXME(davidtwco): This is a hack to detect macros which produce spans of the | ||
| // call site which do not have a macro backtrace. See #61963. |
Contributor
There was a problem hiding this comment.
Should we have some way to enable this to push the proc-macro ecosystem in the right direction?
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 1f1d212 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 30, 2021
Lint missing Abi in ast validation instead of lowering.
Member
|
Failed in rollup: #87639 (comment) |
bors
added
S-waiting-on-author
Contributor
|
Ideally we could fix the code to make the pointed span not change, but either way it's fine. |
Contributor
Author
|
Rebased. |
camelid
added
S-waiting-on-review
inquisitivecrystal
added
the
T-compiler
Collaborator
|
☔ The latest upstream changes (presumably #88208) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit f76442c460c5e29b8015deb14c7f0e9d5bd87738 has been approved by |
bors
added
S-waiting-on-bors
bjorn3
reviewed
Aug 31, 2021
Member
There was a problem hiding this comment.
This will cause the entire function to be marked in ide's instead of just the function signature, which is annoying.
cjgillot
added
S-waiting-on-review
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 8d7d488 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 1, 2021
Lint missing Abi in ast validation instead of lowering.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 1, 2021
Lint missing Abi in ast validation instead of lowering.
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.