Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit 28cf90d with merge 4e7f9014b4dc19485bb3ea6d3ebf68bab256b14f... |
| &mut self, | ||
| ast_stmts: &[Stmt], | ||
| ) -> (&'hir [hir::Stmt<'hir>], Option<&'hir hir::Expr<'hir>>) { | ||
| let mut stmts = SmallVec::<[hir::Stmt<'hir>; 8]>::new(); |
There was a problem hiding this comment.
I don't know if 8 is optimal, but I think it is already used in the current implementation, in alloc_from_iter.
|
☀️ Try build successful - checks-actions |
|
Queued 4e7f9014b4dc19485bb3ea6d3ebf68bab256b14f with parent 6fe0886, future comparison URL. |
|
Finished benchmarking try commit (4e7f9014b4dc19485bb3ea6d3ebf68bab256b14f): comparison url. Summary: This benchmark run did not return any significant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. @bors rollup=never |
|
Neutral results I guess. Maybe it's easier to just close this PR. |
I have this change in #87688 but I think it deserves its own PR and a perf run.
Changes
lower_stmttolower_stmtsand avoid creating aSmallVecfor eachast::Stmt.