Avoid using the copy_nonoverlapping wrapper through mem::replace.#87827
Merged
bors merged 1 commit intorust-lang:masterfrom Aug 8, 2021
Merged
Avoid using the copy_nonoverlapping wrapper through mem::replace.#87827bors merged 1 commit intorust-lang:masterfrom
copy_nonoverlapping wrapper through mem::replace.#87827bors merged 1 commit intorust-lang:masterfrom
Conversation
Member
|
Looks reasonable enough to me. |
Member
|
Yeah this makes sense. |
Member
|
@bors r+ rollup=never |
Collaborator
|
📌 Commit d3dd6cb11db296a59dc0997db65b32403c930cd3 has been approved by |
Collaborator
|
⌛ Testing commit d3dd6cb11db296a59dc0997db65b32403c930cd3 with merge bba5126c336dad13ada2c34b7425aaf94d01c1d9... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d3dd6cb to
a1d014b
Compare
Member
Author
|
@bors r=m-ou-se |
Collaborator
|
📌 Commit a1d014b has been approved by |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Nov 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a much simpler way to achieve the pre-#86003 behavior of
mem::replacenot needing dynamically-sizedmemcpys (at least before inlining), than re-doing #81238 (which needs #86699 or something similar).I didn't notice it until recently, but
ptr::writealready explicitly avoided using the wrapper, whileptr::readjust called the wrapper (and was the reason for us observing any behavior change from #86003 in Rust-GPU).The codegen test I've added fails without the change to
core::ptr::readlike this (ignore thev0mangling, I was using a worktree with it turned on by default, for this):With the
core::ptr::readchange,core::intrinsics::copy_nonoverlappingdoesn't get instantiated and the test passes.r? @m-ou-se cc @nagisa (codegen test) @oli-obk / @RalfJung (miri diagnostic changes)