unwind: make build.rs do clean rebuilds#87977
Closed
gburgessiv wants to merge 1 commit intorust-lang:masterfrom
Closed
unwind: make build.rs do clean rebuilds#87977gburgessiv wants to merge 1 commit intorust-lang:masterfrom
build.rs do clean rebuilds#87977gburgessiv wants to merge 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
added
S-waiting-on-author
gburgessiv
force-pushed
the
unwind-clean-rebuilds
branch
from
11e54d0 to
44f1f1a
Compare
gburgessiv
commented
Aug 24, 2021
Contributor
Author
gburgessiv
left a comment
gburgessiv
left a comment
There was a problem hiding this comment.
Thanks for the feedback!
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit 44f1f1a36f24cea2a3135768f213f45ad3f23055 has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
If the build by this was interrupted or otherwise left incomplete, there could be object files hanging around, which triggers an assertion later. Since we unconditionally rebuild everything here anyway, start with a clean slate each build.
gburgessiv
force-pushed
the
unwind-clean-rebuilds
branch
from
44f1f1a to
90950a1
Compare
Contributor
Author
|
TIL my |
Collaborator
|
☔ The latest upstream changes (presumably #85600) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Contributor
Author
|
Looks like the changes that caused the merge conflict also added a check to tell objects generated from C++ sources apart from objects generated from C sources. Hence, this should be fixed already, so I'll close it out. Thanks again for the review! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the build by this was interrupted or otherwise left incomplete, there
could be object files hanging around, which triggers an assertion later.
Since we unconditionally rebuild everything here anyway, start with a
clean slate each build.
r? @Mark-Simulacrum