Add links for primitives in "jump to definition" feature#88033
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 14, 2021
Merged
Add links for primitives in "jump to definition" feature#88033bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
GuillaumeGomez
added
the
T-rustdoc
Contributor
|
Some changes occurred in intra-doc-links. cc @jyn514 |
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Aug 14, 2021
jyn514
added
the
A-intra-doc-links
GuillaumeGomez
force-pushed
the
jump-to-def-primitive
branch
from
40fb279 to
f94a224
Compare
Member
Author
I'm totally fine with waiting for it! |
JohnCSimon
added
S-waiting-on-review
Member
|
triage: fyi #87073 is still open |
jyn514
added
S-blocked
GuillaumeGomez
force-pushed
the
jump-to-def-primitive
branch
from
f94a224 to
997b3b6
Compare
GuillaumeGomez
added
S-waiting-on-review
Member
Author
|
#87073 has been merged, the PR has been rebased and updated to take the changes into account making it much smaller. Ready for the next review round! :) |
jyn514
suggested changes
Sep 13, 2021
Member
|
You're right, this is a lot simpler now :) |
jyn514
added
requires-nightly
GuillaumeGomez
force-pushed
the
jump-to-def-primitive
branch
from
997b3b6 to
96c42f6
Compare
jyn514
reviewed
Sep 13, 2021
GuillaumeGomez
force-pushed
the
jump-to-def-primitive
branch
from
96c42f6 to
d73c0a3
Compare
Member
Author
|
Updated! |
Member
|
r=me once CI is passing |
Member
Author
|
@bors: r=jyn514 |
Collaborator
|
📌 Commit d73c0a3 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2021
…e, r=jyn514 Add links for primitives in "jump to definition" feature Follow-up of rust-lang#84176. I created a function `primitive_from_str` which is code that was originally in `collect_intra_doc_links::resolve_primitive` to prevent code duplication. I also created the `primitive_link_url` function which is somewhat similar to `primitive_link` but too much different to merge both of them. r? `@jyn514`
This was referenced Sep 13, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 14, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#88033 (Add links for primitives in "jump to definition" feature) - rust-lang#88722 (Make `UnsafeCell::get_mut` const) - rust-lang#88851 (Fix duplicate bounds for const_trait_impl) - rust-lang#88859 (interpreter PointerArithmetic: use new Size helper methods) - rust-lang#88885 (Fix jump def background) - rust-lang#88894 (Improve error message for missing trait in trait impl) - rust-lang#88896 (Reduce possibility of flaky tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #84176.
I created a function
primitive_from_strwhich is code that was originally incollect_intra_doc_links::resolve_primitiveto prevent code duplication.I also created the
primitive_link_urlfunction which is somewhat similar toprimitive_linkbut too much different to merge both of them.Part of #89095.
r? @jyn514