Give CommandEnv OS specific implementations#88064
Closed
ChrisDenton wants to merge 2 commits intorust-lang:masterfrom
Closed
Give CommandEnv OS specific implementations#88064ChrisDenton wants to merge 2 commits intorust-lang:masterfrom
CommandEnv OS specific implementations#88064ChrisDenton wants to merge 2 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #87329) made this pull request unmergeable. Please resolve the merge conflicts. |
Also add unsupported implementation of `CommandEnv`.
ChrisDenton
force-pushed
the
command-envs-os
branch
from
a64772b to
176d0bf
Compare
inquisitivecrystal
added
the
T-libs-api
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #89703) made this pull request unmergeable. Please resolve the merge conflicts. |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #87863 (comment)
This splits
CommandEnvinto Unix and Windows implementations (as well as one for "unsupported"). This will allow the implementations to further diverge in the future. It essentially reverts #87863 for Unixes. The Windows implementation has also been trimmed down to only code that's used for Windows.This PR also removes the
applyfunction from the Unix implementation. I could not find it being used anywhere in std after grepping.r? @m-ou-se