Revert "Auto merge of #82776 - jyn514:extern-url-fallback"#88646
Closed
jyn514 wants to merge 1 commit intorust-lang:masterfrom
Closed
Revert "Auto merge of #82776 - jyn514:extern-url-fallback"#88646jyn514 wants to merge 1 commit intorust-lang:masterfrom
jyn514 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #87073) made this pull request unmergeable. Please resolve the merge conflicts. |
apiraino
added
the
T-rustdoc
JohnCSimon
added
S-waiting-on-review
joelpalmer
added
S-waiting-on-review
Member
Author
|
@ehuss have you had time to think about this? I kind of regret adding this in hindsight ... |
Contributor
|
I'm sorry for not responding sooner. I'd like to be able to carve some time out to really understand the different use cases, and try to see what kind of flags would help address them. This has been pretty high in my todo list, I just haven't been able to get to it, yet. |
Member
Author
|
@ehuss if it helps, I'm willing to write up an RFC for this so we get more feedback from the community :) |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
Member
Author
|
I don't want to be responsible for this. @ehuss feel free to open the same PR if you think it's useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b1928aa, reversing
changes made to 99b73e8.
I don't have time to follow up on this right now, and @ehuss said it was breaking things for cargo in the meantime.
r? @ehuss (this is just a straight revert, so I don't expect you to review the code changes, just that tests pass and you think it's a good idea.)