Tokenize emoji as if they were valid identifiers #88781
Merged
bors merged 11 commits intorust-lang:masterfrom Nov 25, 2021
Merged
Tokenize emoji as if they were valid identifiers #88781bors merged 11 commits intorust-lang:masterfrom
bors merged 11 commits intorust-lang:masterfrom
Conversation
Contributor
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
cc @Manishearth |
Manishearth
reviewed
Sep 9, 2021
Manishearth
changed the title
oli-obk
reviewed
Sep 13, 2021
| LL | fn i_like_to_😅_a_lot() -> 👀 { | ||
| | ^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: identifiers cannot contain emoji: `ABig👩👩👧👧Family` |
Contributor
There was a problem hiding this comment.
🤣 the family got deaggregated
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit 5979ed5 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 13, 2021
Tokenize emoji as if they were valid identifiers In the lexer, consider emojis to be valid identifiers and reject them later to avoid knock down parse errors. Partially address rust-lang#86102.
Member
bors
added
S-waiting-on-author
oli-obk
reviewed
Sep 13, 2021
| /// Places where identifiers that contain invalid Unicode codepoints but that look like they | ||
| /// should be. Useful to avoid bad tokenization when encountering emoji. We group them to | ||
| /// provide a single error per unique incorrect identifier. | ||
| pub bad_unicode_identifiers: Lock<FxHashMap<Symbol, Vec<Span>>>, |
Contributor
There was a problem hiding this comment.
Suggested change
| pub bad_unicode_identifiers: Lock<FxHashMap<Symbol, Vec<Span>>>, | |
| pub bad_unicode_identifiers: Lock<VecMap<Symbol, Vec<Span>>>, |
Hash maps are great, until they aren't XD
Contributor
Author
There was a problem hiding this comment.
Tried using it's API, but it really doesn't fit well with this case. I'm sorting the output before emitting the diagnostic instead.
estebank
force-pushed
the
emoji-idents
branch
from
5979ed5 to
30f9807
Compare
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit 30f9807 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 14, 2021
Tokenize emoji as if they were valid identifiers In the lexer, consider emojis to be valid identifiers and reject them later to avoid knock down parse errors. Partially address rust-lang#86102.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 14, 2021
Tokenize emoji as if they were valid identifiers In the lexer, consider emojis to be valid identifiers and reject them later to avoid knock down parse errors. Partially address rust-lang#86102.
bors
added
the
S-waiting-on-author
estebank
added
the
S-blocked
estebank
added a commit
to estebank/cargo
that referenced
this pull request
Nov 24, 2021
This change is needed to land rust-lang/rust#88781, as it changes the handling of emojis in source code to treat them as identifiers.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Nov 24, 2021
Change test to not trigger emoji error This change is needed to land rust-lang/rust#88781, as it changes the handling of emojis in source code to treat them as identifiers.
Contributor
Author
|
Once rust-lang/cargo#10117 is pulled into this repo, we can merge this PR. |
Contributor
|
@estebank Feel free to update cargo in this PR ( |
Contributor
Author
|
@bors r=oli-obk |
Collaborator
|
📌 Commit d929164 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit d929164 with merge 9dc1d2de4eb6199a77eedd3b61e644919794b59c... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Contributor
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (23a4366): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the lexer, consider emojis to be valid identifiers and reject
them later to avoid knock down parse errors.
Partially address #86102.