Skip to content

Fix debuginfo tests for the latest version of the Windows SDK. #88842

Merged
bors merged 2 commits intorust-lang:masterfrom
wesleywiser:fix_dbg_tests_windows_sdk
Sep 20, 2021
Merged

Fix debuginfo tests for the latest version of the Windows SDK. #88842
bors merged 2 commits intorust-lang:masterfrom
wesleywiser:fix_dbg_tests_windows_sdk

Conversation

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Sep 11, 2021

Re-enable the tests that were disabled to fix CI.

Changes:

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 11, 2021

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2021
@wesleywiser wesleywiser force-pushed the fix_dbg_tests_windows_sdk branch from 2c3d5eb to e2a6464 Compare September 11, 2021 01:33
@wesleywiser
Copy link
Member Author

wesleywiser commented Sep 11, 2021 •
edited
Loading

Note: the i686-pc-windows-msvc target's cdb has had issues correctly visualizing enums in the past. I'm trying it again to see if the update fixes those issues but there is a chance this will fail in CI.

@bors rollup=iffy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wesleywiser wesleywiser mentioned this pull request Sep 11, 2021
Closed
@wesleywiser
Fix debuginfo tests for the latest version of the Windows SDK.
e156df2 
- Cdb now correctly visualizes enums.
- Cdb doesn't render emoji characters in `OSStr` anymore.
- Cdb doesn't always render `str` correctly (rust-lang#88840)
@wesleywiser wesleywiser force-pushed the fix_dbg_tests_windows_sdk branch from e2a6464 to e156df2 Compare September 11, 2021 01:46
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 13, 2021
@michaelwoerister
Copy link
Member

michaelwoerister commented Sep 15, 2021

Thanks for fixing this, @wesleywiser!

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

📌 Commit e156df2 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@bors
Copy link
Collaborator

bors commented Sep 15, 2021

⌛ Testing commit e156df2 with merge c950f7fd4793cc466326a5e1856d3e6337ddbb66...

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Sep 15, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Sep 15, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2021
@michaelwoerister
Copy link
Member

michaelwoerister commented Sep 15, 2021 •
edited
Loading

Looks like a spurious error:

curl: (6) Could not resolve host: ci-mirrors.rust-lang.org

https://github.com/rust-lang-ci/rust/runs/3608424333#step:15:33

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2021
@michaelwoerister michaelwoerister added the A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) label Sep 15, 2021
@ehuss
Copy link
Contributor

ehuss commented Sep 16, 2021

@wesleywiser FYI, I needed to disable src/test/debuginfo/mutex.rs in #88977 because the version of CDB updated to 10.0.22000.1 this morning, and the output changed in ways that I wasn't comfortable updating. Beyond the : 0 output differences, there were various [<Raw View>] strings and other stuff that I wasn't familiar with.

@wesleywiser
Copy link
Member Author

wesleywiser commented Sep 16, 2021

@ehuss Thanks for the heads up! I'll take a look at that as well.

@bors
Copy link
Collaborator

bors commented Sep 20, 2021

⌛ Testing commit e156df2 with merge e71925a...

@bors
Copy link
Collaborator

bors commented Sep 20, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing e71925a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2021
@bors bors merged commit e71925a into rust-lang:master Sep 20, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 20, 2021
@rust-timer
Copy link
Collaborator

rust-timer commented Sep 20, 2021

Finished benchmarking commit (e71925a): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoerister michaelwoerister

Labels

A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.57.0

Development

Successfully merging this pull request may close these issues.

10 participants

@wesleywiser @rust-highfive @rust-log-analyzer @michaelwoerister @bors @ehuss @rust-timer @Mark-Simulacrum @apiraino @rustbot