Resolve issue : Somewhat confusing error with extended_key_value_attributes#89023
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 24, 2021
Merged
Resolve issue : Somewhat confusing error with extended_key_value_attributes#89023bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
nagisa
reviewed
Sep 17, 2021
Member
|
Please squash the commits in order to retain a clean history after the merge happens. |
Member
|
@Wardenfar If you edit the PR description to be |
camelid
added
A-parser
Wardenfar
force-pushed
the
issue-85066
branch
from
ba3f63b to
59d5eb2
Compare
Contributor
Author
Member
|
@bors r+ thanks! |
Collaborator
|
📌 Commit 59d5eb2 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 19, 2021
Resolve issue 85066 Fixes rust-lang#85066
Member
|
Failed in rollup: #89087 (comment) |
bors
added
S-waiting-on-author
Fix : use struct_dummy Fix different os messages
Wardenfar
force-pushed
the
issue-85066
branch
from
59d5eb2 to
250a3e4
Compare
Contributor
Author
|
@JohnTitor i think i fixed it |
Member
|
@bors r+ |
Collaborator
|
📌 Commit 250a3e4 has been approved by |
bors
added
S-waiting-on-bors
Member
|
This PR could use a better title |
Wardenfar
changed the title
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 23, 2021
Resolve issue : Somewhat confusing error with extended_key_value_attributes Fixes rust-lang#85066
This was referenced Sep 23, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2021
…ingjubilee Rollup of 7 pull requests Successful merges: - rust-lang#88612 (Add a better error message for rust-lang#39364) - rust-lang#89023 (Resolve issue : Somewhat confusing error with extended_key_value_attributes) - rust-lang#89148 (Suggest `_` in turbofish if param will be inferred from fn argument) - rust-lang#89171 (Run `no_core` rustdoc tests only on Linux) - rust-lang#89176 (Change singular to plural) - rust-lang#89184 (Temporarily rename int_roundings functions to avoid conflicts) - rust-lang#89200 (Fix typo) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85066