Avoid a couple of Symbol::as_str calls in cg_llvm #89072
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 25, 2021
Merged
Avoid a couple of Symbol::as_str calls in cg_llvm #89072bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
bjorn3
added
C-cleanup
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #89089) made this pull request unmergeable. Please resolve the merge conflicts. |
bjorn3
force-pushed
the
less_symbol_as_str
branch
from
720bbf5 to
0ec871b
Compare
michaelwoerister
approved these changes
Sep 22, 2021
Member
michaelwoerister
left a comment
michaelwoerister
left a comment
There was a problem hiding this comment.
Thanks, @bjorn3! r=me once rebased.
It is used exactly once and can be replaced with the equally fast .as_str().len()
bjorn3
force-pushed
the
less_symbol_as_str
branch
from
0ec871b to
df72749
Compare
Member
Author
|
@bors r=michaelwoerister |
Collaborator
|
📌 Commit df72749 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 24, 2021
…lwoerister Avoid a couple of Symbol::as_str calls in cg_llvm This should improve performance a tiny bit. Also remove `Symbol::len` and make `SymbolIndex` private.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2021
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#88893 (Add 1.56.0 release notes) - rust-lang#89001 (Be explicit about using Binder::dummy) - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm ) - rust-lang#89104 (Simplify scoped_thread) - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code) - rust-lang#89210 (Add missing time complexities to linked_list.rs) - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well) - rust-lang#89221 (Give better error for `macro_rules! name!`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve performance a tiny bit. Also remove
Symbol::lenand makeSymbolIndexprivate.