build abstract consts without typeck for fully qualified associated consts#89231
Closed
BoxyUwU wants to merge 1 commit intorust-lang:masterfrom
Closed
build abstract consts without typeck for fully qualified associated consts#89231BoxyUwU wants to merge 1 commit intorust-lang:masterfrom
BoxyUwU wants to merge 1 commit intorust-lang:masterfrom
Conversation
4e700fb to
428996c
Compare
This comment has been minimized.
This comment has been minimized.
428996c to
5b99704
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #90119) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
gonna close this I dont think theres any point keeping it open, my point has been proven 🤣 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we build an abstract const for the const arg in
foo::<{ <T as Trait>::ASSOC }>()we currently typeck the anon constant and then build an abstract const by walking thir. this PR adds a special case for when the anon const is a fully qualified assoc const, instead of typeck'ing and using thir we will just lower it to to defid + substs pair where the defid is the associated item on the trait (the same result using thir would give us but without the cycles :P).r? @lcnr