Default to disabling the new pass manager for the s390x arch targets.#89666
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 8, 2021
Merged
Conversation
Contributor
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nagisa
reviewed
Oct 8, 2021
hkratz
force-pushed
the
disable_new_llvm_pass_manager_on_s390x_take_two
branch
from
84cfa17 to
91801b1
Compare
hkratz
force-pushed
the
disable_new_llvm_pass_manager_on_s390x_take_two
branch
from
91801b1 to
4593d78
Compare
Member
|
@bors r+ Thanks! |
Collaborator
|
📌 Commit 4593d78 has been approved by |
bors
added
S-waiting-on-bors
Member
Member
|
Should the priority of this be bumped since it fixes CI timeouts and in general may speed up CI? E.g., to |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Oct 8, 2021
…anager_on_s390x_take_two, r=nagisa Default to disabling the new pass manager for the s390x arch targets. This hack disables the new LLVM pass manager by default for s390x arch targets until the performance issues are fixed (see rust-lang#89609). The command line option `-Z new-llvm-pass-manager=(yes|no)` continues to take precedence over this default.
Member
|
@bors p=1 |
Collaborator
Member
Collaborator
|
☀️ Test successful - checks-actions |
Member
🎉 |
Collaborator
|
Finished benchmarking commit (54bb4fe): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hack disables the new LLVM pass manager by default for s390x arch targets until the performance issues are fixed (see #89609). The command line option
-Z new-llvm-pass-manager=(yes|no)continues to take precedence over this default.