Don't emit a warning for empty rmeta files.#90072
Conversation
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ehuss
added
the
beta-nominated
|
Nominating for beta just to avoid the warning spam when running |
|
@bors r+ p=1 I think this makes sense. FWIW, it may be worth putting in the effort to avoid the user-visible tracing warnings, because they don't provide guidance on what to do -- we should strive to not give such warnings to users, IMO. Unconditional warnings with a help: text would already be an improvement. |
|
📌 Commit 6f91505 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
apiraino
added
the
T-compiler
|
Finished benchmarking commit (40ebd07): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
rustbot
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
…ulacrum [beta] backports * Don't emit a warning for empty rmeta files. rust-lang#90072 * Erase late-bound regions before computing vtable debuginfo name. rust-lang#90050 * Fix wrong niche calculation when 2+ niches are placed at the start rust-lang#90040 * Revert rust-lang#86011 to fix an incorrect bound check rust-lang#90025 * Fix macro_rules! duplication when reexported in the same module rust-lang#89867 * Bump cargo to include rust-lang/cargo#9979 - Fix fetching git repos after a force push. r? `@Mark-Simulacrum`
8 participants
This avoids displaying a warning when attempting to load an empty rmeta file. Warnings were enabled via #89634 which can cause a lot of noise (for example, running
./x.py check). rustc generates empty rmeta files for things like binaries, which can happen when checking libraries as unittests.Closes #89795