Make `intrinsics::write_bytes` const by lilasta · Pull Request #90081 · rust-lang/rust

lilasta · 2021-10-20T02:54:02Z

This is required to constify MaybeUninit::zeroed and (*mut T)::write_bytes.

Tracking issue: #86302

rust-highfive · 2021-10-20T02:54:05Z

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

library/core/src/intrinsics.rs

oli-obk · 2021-10-20T09:54:33Z

blocked on #90041

library/core/src/intrinsics.rs

oli-obk · 2021-10-25T12:46:00Z

Should I create a tracking issue?

I think you can just point to the const_mut_refs tracking issue, as there is no reason not to stabilize write_bytes as const once we have mutable references

lilasta · 2021-10-25T15:28:47Z

I just found the const_ptr_write tracking issue (86302), so I changed to it.

oli-obk · 2021-10-25T15:57:52Z

@bors r+

bors · 2021-10-25T15:57:53Z

📌 Commit 15c2613a86a227937058a7d4ff68068cce5f4f1e has been approved by oli-obk

oli-obk · 2021-10-25T15:57:58Z

@bors rollup

WaffleLapkin · 2021-10-25T16:59:01Z

blocked on #90041

Isn't it still blocked?

oli-obk · 2021-10-25T17:01:06Z

@bors r- uuuh gotta check. Sorry, thanks for the ping

bors · 2021-11-13T08:47:27Z

☔ The latest upstream changes (presumably #90041) made this pull request unmergeable. Please resolve the merge conflicts.

lilasta · 2021-11-16T01:42:54Z

Rebased.

oli-obk · 2021-11-16T13:08:16Z

library/core/src/intrinsics.rs

similarly to the other PR, please just call this function nop and mention on the const_eval_select call that it's just a debug assertion and so it's not a problem if CTFE does not check it, even if it checks some of the rules

ecstatic-morse · 2021-11-23T00:46:32Z

@woppopo MaybeUninit::zeroed was one of the functions that the Rust-for-Linux devs mentioned specifically in today's CTCFT as being useful in a const context. Any chance you'd be able to incorporate Oli's feedback in the near future? It would be nice to get this onto nightly now that it's unblocked.

lilasta · 2021-11-23T06:16:35Z

Thank you for telling me. I added #[cfg(debug_assertions)] to the functions needed for checking, and unified with the same style as #90041.

oli-obk · 2021-11-23T06:48:18Z

@bors r+ rollup

bors · 2021-11-23T06:48:19Z

📌 Commit e8e02d9 has been approved by oli-obk

Make `intrinsics::write_bytes` const This is required to constify `MaybeUninit::zeroed` and `(*mut T)::write_bytes`. Tracking issue: rust-lang#86302

camelid · 2021-12-10T23:40:18Z

It seems this branch was pushed to after the PR was approved, so it needs a new review.

camelid · 2021-12-10T23:40:28Z

@bors r-

oli-obk · 2021-12-11T09:31:56Z

@bors r+

bors · 2021-12-11T09:31:57Z

📌 Commit 89b2e0c has been approved by oli-obk

Make `intrinsics::write_bytes` const This is required to constify `MaybeUninit::zeroed` and `(*mut T)::write_bytes`. Tracking issue: rust-lang#86302

…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#90081 (Make `intrinsics::write_bytes` const) - rust-lang#91643 (asm: Allow using r9 (ARM) and x18 (AArch64) if they are not reserved by the current target) - rust-lang#91737 (Make certain panicky stdlib functions behave better under panic_immediate_abort) - rust-lang#91750 (rustdoc: Add regression test for Iterator as notable trait on &T) - rust-lang#91764 (Do not ICE when suggesting elided lifetimes on non-existent spans.) - rust-lang#91780 (Remove hir::Node::hir_id.) - rust-lang#91797 (Fix zero-sized reference to deallocated memory) - rust-lang#91806 (Make `Unique`s methods `const`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned joshtriplett Oct 20, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2021

This comment has been minimized.

Sign in to view

oli-obk reviewed Oct 20, 2021

View reviewed changes

library/core/src/intrinsics.rs Outdated Show resolved Hide resolved

oli-obk added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Oct 20, 2021

oli-obk reviewed Oct 20, 2021

View reviewed changes

library/core/src/intrinsics.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

lilasta marked this pull request as draft October 24, 2021 10:08

This comment has been minimized.

Sign in to view

lilasta marked this pull request as ready for review October 25, 2021 06:13

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 25, 2021

apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 28, 2021

oli-obk reviewed Nov 16, 2021

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 23, 2021

matthiaskrgr mentioned this pull request Nov 23, 2021

Rollup of 7 pull requests #91157

Closed

Make intrinsics::write_bytes const

89b2e0c

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 10, 2021

camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 10, 2021

camelid assigned oli-obk and unassigned joshtriplett Dec 10, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2021

matthiaskrgr mentioned this pull request Dec 11, 2021

Rollup of 6 pull requests #91790

Closed

matthiaskrgr mentioned this pull request Dec 11, 2021

Rollup of 8 pull requests #91813

Merged

bors merged commit 9383a49 into rust-lang:master Dec 12, 2021

rustbot added this to the 1.59.0 milestone Dec 12, 2021

lilasta deleted the const_write_bytes branch December 12, 2021 03:57

lilasta mentioned this pull request Dec 13, 2021

Tracking Issue for const_ptr_write #86302

Closed

9 tasks

Uh oh!

Conversation

lilasta commented Oct 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Oct 20, 2021

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Oct 20, 2021

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

oli-obk commented Oct 25, 2021

Uh oh!

lilasta commented Oct 25, 2021

Uh oh!

oli-obk commented Oct 25, 2021

Uh oh!

bors commented Oct 25, 2021

Uh oh!

oli-obk commented Oct 25, 2021

Uh oh!

WaffleLapkin commented Oct 25, 2021

Uh oh!

oli-obk commented Oct 25, 2021

Uh oh!

bors commented Nov 13, 2021

Uh oh!

lilasta commented Nov 16, 2021

Uh oh!

oli-obk Nov 16, 2021

Choose a reason for hiding this comment

Uh oh!

ecstatic-morse commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lilasta commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Nov 23, 2021

Uh oh!

bors commented Nov 23, 2021

Uh oh!

camelid commented Dec 10, 2021

Uh oh!

camelid commented Dec 10, 2021

Uh oh!

oli-obk commented Dec 11, 2021

Uh oh!

bors commented Dec 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

lilasta commented Oct 20, 2021 •

edited

Loading

ecstatic-morse commented Nov 23, 2021 •

edited

Loading

lilasta commented Nov 23, 2021 •

edited

Loading