Merged
Conversation
Noticed that this wasn't covered by any of existing tests. The const checking and const qualification, which currently shares the implementation with promotion, will likely need a different behaviour here (see issue rust-lang#90193).
Also, remove the highlighting of the search bar in disabled state. This reduces flicker when loading a page.
This lint is not yet ready for stable use, primarily due to false positives in edge cases; we want to test it out more before stabilizing.
…nd, r=Mark-Simulacrum Feature gate + make must_not_suspend allow-by-default Fixes rust-lang#89798 and patches over rust-lang#89562 (not a true fix, since we're just disabling the lint for now).
…t-more-gracefully, r=Mark-Simulacrum Handling submodule update failures more gracefully from x.py Addresses rust-lang#80498 Handling the case where x.py can't check out the right commit of a submodule, because the submodule has local edits that would be overwritten by the checkout, more gracefully. The error is printed in detail, with some hints on how to revert the local changes to the submodule.
…omez rustdoc: remove flicker during page load The search bar has a `:disabled` style that makes it grey, which creates a distracting flicker from grey to white when the page finishes loading. The search bar should stay the same color throughout page load. A blank white search bar might create an incorrect impression for users with JS turned off. Since they can't use the search functionality, I've hidden the search bar in noscript.css. Fixes rust-lang#90246 r? `@GuillaumeGomez` Demo: https://rustdoc.crud.net/jsha/flashy-searchbar/std/string/struct.String.html
…n514 Fix rare ICE during typeck in rustdoc scrape_examples While testing the `--scrape-examples` extension on the [wasmtime](https://github.com/bytecodealliance/wasmtime) repository, I found some additional edge cases. Specifically, when asking to typecheck a body containing a function call, I would sometimes get an ICE if: * The body doesn't exist * The function's HIR node didn't have a type This adds checks for both of those conditions. (Also this updates a test to check that the sources of a reverse-dependency are correctly generated and linked.) r? `@jyn514`
…amelid Document `doc(keyword)` unstable attribute r? `@camelid`
…r=Mark-Simulacrum Test that promotion follows references when looking for drop Noticed that this wasn't covered by any of existing tests. The const checking and const qualification, which currently shares the implementation with promotion, will likely need a different behaviour here (see issue rust-lang#90193).
Remove `rustc_hir::hir_id::HirIdVec` See rust-lang#90408 (comment): > IIRC, `HirIdVec` is never used, you can delete it. PR rust-lang#72015 has been abandoned. r? `@cjgillot`
Remove unnecessary `Option` from `promote_candidate` return type
Member
Author
|
@bors r+ p=8 rollup=never |
Collaborator
|
📌 Commit 6ce0ef5 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 6ce0ef5 with merge 49eb8ebed74e7127a1bf5028b514ade87af12ff5... |
Member
Collaborator
This comment has been minimized.
This comment has been minimized.
Member
|
Well that was the wrong PR to sent the comment to 😅 |
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (e9b0d99): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
doc(keyword)unstable attribute #90398 (Documentdoc(keyword)unstable attribute)rustc_hir::hir_id::HirIdVec#90450 (Removerustc_hir::hir_id::HirIdVec)Optionfrompromote_candidatereturn type #90452 (Remove unnecessaryOptionfrompromote_candidatereturn type)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup