Closed
Conversation
Inspired by rust-lang#90521 , and by the various `must_use` PRs; in all of those cases, the submitter of the PR could know that `relnotes` applied, but couldn't apply it themselves.
People should be able to help triage by observing that a change needs an FCP before we can apply it.
…r=notriddle Simplify js tester a bit r? `@notriddle`
…oshtriplett Clean up some `-Z unstable-options` in tests. Several of these tests were for features that have been stabilized, or otherwise don't need `-Z unstable-options`.
…riplett
Add more text and examples to `carrying_{add|mul}`
`feature(bigint_helper_methods)` tracking issue rust-lang#85532
cc `@clarfonthey`
…r=Mark-Simulacrum rustbot allow labels `relnotes` was inspired by rust-lang#90521 , and by the various `must_use` PRs; in all of those cases, the submitter of the PR could know that `relnotes` applied, but couldn't apply it themselves. For `needs-fcp`, I think people should be able to help triage by observing that a change needs an FCP before we can apply it.
Member
Author
|
@bors r+ p=4 rollup=never |
Collaborator
|
📌 Commit 42fd51a has been approved by |
bors
added
the
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Z unstable-optionsin tests. #90554 (Clean up some-Z unstable-optionsin tests.)carrying_{add|mul}#90556 (Add more text and examples tocarrying_{add|mul})Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup