Merged
Conversation
Now AddressSanitizerOptions is a struct, but at least the change was tiny. r? nikic
This makes the inherent method ptr::swap unstably
const, as well as slice::swap{,_unchecked}.
The span has been recuded to the actual ident, instead of linting the *whole* macro.
The `unreachable!` docs previously did not mention that there was a second
form, `unreachable!("message")` that could be used to specify a custom panic
message,
The docs now mention this in the same style as currently used for `unimplemented!`:
https://doc.rust-lang.org/core/macro.unimplemented.html#panics
This happened later in the stream than the other changes, but the fix is overlapping. Fix taken from a55c4ec in LLVM.
As discussed here rust-lang#88300 (comment) exit is (conventionally) a library function, with _exit being the actual system call. I have checked the other references and they say "if the process terminated by calling `exti`". I think despite the slight imprecision (strictly, it should read iff ... `_exit`), this is clearer. Anyone who knows about the distinction between `exit` and `_exit` will not be confused. `_exit` is the correct traditional name for the system call, despite Linux calling it `exit_group` or `exit`: https://www.freebsd.org/cgi/man.cgi?query=_exit&sektion=2&n=1 Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
With cross-reference. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
As discussed here rust-lang#88300 (comment) I felt this was the best place to put this (rather than next to ExitStatusExt). After all, it's a property of the ExitStatus type on Unix. Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
…ikic rustc_llvm: update PassWrapper for recent LLVM Now AddressSanitizerOptions is a struct, but at least the change was tiny. r? `@nikic`
Extend the const swap feature Adds the `const_swap` feature gate to three more swap functions. cc tracking issue rust-lang#83163 ```Rust impl<T> [T] { pub const fn swap(&mut self, a: usize, b: usize); pub const unsafe fn swap_unchecked(&mut self, a: usize, b: usize); } impl<T: ?Sized> *mut T { pub const unsafe fn swap(self, with: *mut T); }
…htriplett Unix ExitStatus comments and a tiny docs fix Some nits left over from rust-lang#88300
Shorten Span of unused macro lints The span has been reduced to the actual ident of the macro, instead of linting the *whole* macro. Closes rust-lang#90745 r? ``@estebank``
…mments, r=notriddle Add more comments to explain the code to generate the search index Fixes rust-lang#90766. I tried to put comments when the code wasn't easy to understand at first sight and added more documentation on the recursive function. Please tell me if I misused the terminology or if comments can be improved or added into other places. r? `@notriddle`
…sage, r=dtolnay
Document `unreachable!` custom panic message
The `unreachable!` docs previously did not mention that there was a second form, `unreachable!("message")` that could be used to specify a custom panic message,
The docs now mention this feature in the same wording as currently used for `unimplemented!`:
https://doc.rust-lang.org/core/macro.unimplemented.html#panics
rustc_feature: Convert `BuiltinAttribute` from tuple to a struct The tuple starts having too many fields. Noticed while reviewing rust-lang#88681.
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 5e7c031 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (e90c5fb): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
unreachable!custom panic message #90798 (Documentunreachable!custom panic message)BuiltinAttributefrom tuple to a struct #90826 (rustc_feature: ConvertBuiltinAttributefrom tuple to a struct)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup