Rollup of 6 pull requests#90862
Closed
matthiaskrgr wants to merge 14 commits intorust-lang:masterfrom
Closed
Conversation
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
…d the conclusion that the code readibility wasn't worth the almost unnoticeable perf improvement
rustdoc: use Type::def_id() instead of Type::def_id_no_primitives() For: rust-lang#90187 r? `@jyn514`
…sts, r=wesleywiser Group commandline tests in a directory I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
…ance, r=camelid Remove unneeded FIXMEs comments in search index generation Original comment: > Instead of recreating a new `vec` for each arguments, we re-use the same. The impact on performance should be minor but worth a try. After testing it, we reached the conclusion that the code readability drop wasn't worth the almost unnoticeable performance improvement. r? ```@camelid```
…e, r=michaelwoerister Fix trait object error code closes rust-lang#90768 I `grep`:d and changed the occurrences that seemed relevant. Please let me know what you think and if anything is missing!
…e_inputs_output, r=jackh726 Normalize both arguments of `equate_normalized_input_or_output` Fixes rust-lang#90638 Fixes rust-lang#90612 Temporary fix for a more complex underlying problem stemming from an inability to normalize closure substs during typecheck. r? ```@jackh726```
…uillaumeGomez rustdoc: Use an empty Vec instead of Option<Vec>
Member
Author
|
@bors r+ rollup=never p=6 |
Collaborator
|
📌 Commit c35d057 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit c35d057 with merge 13cf9f7d1368900b98f44117d57fde3a27cfdd7b... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
bors
added
S-waiting-on-bors
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
⌛ Testing commit c35d057 with merge f5b6c70ac80ec3a33f1c823f731687f8ba40c37b... |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Member
Author
|
✨ |
bors
added
S-waiting-on-bors
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
@bors retry |
Collaborator
|
⌛ Testing commit c35d057 with merge 96d6149811d7188684fd7befb2dcf69112b8199b... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
equate_normalized_input_or_output#90801 (Normalize both arguments ofequate_normalized_input_or_output)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup