Skip to content

Basic block predecessors in mir textual representation#90868

Closed
simonvandel wants to merge 2 commits intorust-lang:masterfrom
simonvandel:mir-dump-preds
Closed

Basic block predecessors in mir textual representation#90868
simonvandel wants to merge 2 commits intorust-lang:masterfrom
simonvandel:mir-dump-preds

Conversation

@simonvandel
Copy link
Contributor

@simonvandel simonvandel commented Nov 13, 2021

Similiar to how LLVM-IR includes ; preds = %bb1 in its textual output.
Makes it a bit nicer to read mir dumps.

@rust-highfive
Copy link
Contributor

rust-highfive commented Nov 13, 2021

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
nagisa
nagisa reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine, but ideally the comment with predecessors would come after the line that has block name, rather than before the block itself. This is how our remark comments show up in other places.

That is, I think the output should look more like

    bb1: {                                 // preds: [bb0]

@nagisa nagisa added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2021
@bors
Copy link
Collaborator

bors commented Dec 3, 2021

☔ The latest upstream changes (presumably #91469) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnCSimon
Copy link
Member

JohnCSimon commented Jan 23, 2022

Ping from triage:
@simonvandel can you post your status on this PR and address the comment?
If it's ready for review send a message containing
@rustbot ready

@JohnCSimon
Copy link
Member

JohnCSimon commented Feb 12, 2022

Ping from triage:
@simonvandel can you post your status on this PR address the comment and resolve the merge conflict? Thank you.

@simonvandel
Basic block predecessors in mir textual representation
8d48733 
Similiar to how LLVM-IR includes `; preds = %bb1` in its textual output.
Makes it a bit nicer to read mir dumps.
@simonvandel
Copy link
Contributor Author

simonvandel commented Feb 19, 2022

Sorry for the slow response.
Addressed the comment, and rebased on master.

@nagisa
Copy link
Member

nagisa commented Feb 19, 2022

@bors r+ Thanks!

@bors
Copy link
Collaborator

bors commented Feb 19, 2022

📌 Commit 8d48733 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Feb 20, 2022

☔ The latest upstream changes (presumably #94174) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2022
@nagisa
Copy link
Member

nagisa commented Feb 27, 2022

@simonvandel this needs a rebase.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2022
@JohnCSimon
Copy link
Member

JohnCSimon commented Apr 11, 2022

@simonvandel

Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Apr 11, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nagisa nagisa nagisa left review comments

Assignees

@nagisa nagisa

Labels

S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@simonvandel @rust-highfive @rust-log-analyzer @bors @JohnCSimon @nagisa @apiraino @rustbot