Mark <*const _>::align_offset and <*mut _>::align_offset as const fn#90958
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 17, 2021
Merged
Mark <*const _>::align_offset and <*mut _>::align_offset as const fn#90958bors merged 2 commits intorust-lang:masterfrom
<*const _>::align_offset and <*mut _>::align_offset as const fn#90958bors merged 2 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for doing this one first! Please add a tracking issue that raises the concern that at compile time we will always get usize::MAX and that it is important that this gets talked about before stabilisation |
5 tasks
Member
Author
|
@oli-obk done |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit f926c0e has been approved by |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 17, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90733 (Build musl dist artifacts with debuginfo enabled) - rust-lang#90787 (Add `#[inline]`s to `SortedIndexMultiMap`) - rust-lang#90920 (:arrow_up: rust-analyzer) - rust-lang#90933 (Fix await suggestion on non-future type) - rust-lang#90935 (Alphabetize language features) - rust-lang#90949 (update miri) - rust-lang#90958 (Mark `<*const _>::align_offset` and `<*mut _>::align_offset` as `const fn`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Member
|
Please make sure to Cc @rust-lang/wg-const-eval for every new use of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR marks the following APIs as
const:constimplementation simply returnsusize::MAX.Previous discussion: #90607 (comment)
r? @oli-obk