Merged
Conversation
GuillaumeGomez
added
the
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
camelid
reviewed
Nov 24, 2021
GuillaumeGomez
force-pushed
the
improve-rustdoc-gui-ci
branch
from
e7d54f4 to
94575e1
Compare
Collaborator
|
☔ The latest upstream changes (presumably #91203) made this pull request unmergeable. Please resolve the merge conflicts. |
jsha
approved these changes
Nov 25, 2021
GuillaumeGomez
force-pushed
the
improve-rustdoc-gui-ci
branch
from
94575e1 to
e340478
Compare
Merged
Member
Author
|
@bors: r=jsha |
Collaborator
|
📌 Commit e340478 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc `@jyn514` r? `@jsha`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc ``@jyn514`` r? ``@jsha``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 25, 2021
…ci, r=jsha Improve rustdoc-gui CI As commented [here](rust-lang#91179 (comment)): When the text isn't displayed, the color returned by puppeteer is always `rgba(0,0,0,0)`, which is definitely not the right value. To prevent this error from happening again, `browser-ui-test` will now fail if a CSS color check is run when the text isn't displayed. Either this PR or rust-lang#91179 is merged first, they'll conflict because I made changes to the same test file. cc ```@jyn514``` r? ```@jsha```
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (a7836bf): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As commented here:
When the text isn't displayed, the color returned by puppeteer is always
rgba(0,0,0,0), which is definitely not the right value. To prevent this error from happening again,browser-ui-testwill now fail if a CSS color check is run when the text isn't displayed.Either this PR or #91179 is merged first, they'll conflict because I made changes to the same test file.
cc @jyn514
r? @jsha