Remove --display-doctest-warnings

[jyn514]

--display-doctest-warnings can be replicated in full with other existing features, there's no
need to have a separate option for it. This removes the option and documents the combination of other features to replicate it.

This also fixes a bug where --test-args=--show-output had no effect.

cc @ollie27, #73314 (comment)
Fixes #41574

r? @GuillaumeGomez

[camelid]

This also fixes a bug where --test-args=--show-output had no effect.

Do you think you could separate that into its own commit? It'd make it easier to understand what's being changed.

[jyn514]

Do you think you could separate that into its own commit? It'd make it easier to understand what's being changed.

Not really? This was the fix:

diff --git a/src/librustdoc/doctest.rs b/src/librustdoc/doctest.rs
index de4a3732e73..56ccdfae1d8 100644
--- a/src/librustdoc/doctest.rs
+++ b/src/librustdoc/doctest.rs
@@ -208,29 +205,19 @@
     Ok(())
 }
 
-crate fn run_tests(
-    mut test_args: Vec<String>,
-    nocapture: bool,
-    display_doctest_warnings: bool,
-    tests: Vec<test::TestDescAndFn>,
-) {
+crate fn run_tests(mut test_args: Vec<String>, nocapture: bool, tests: Vec<test::TestDescAndFn>) {
     test_args.insert(0, "rustdoctest".to_string());
     if nocapture {
         test_args.push("--nocapture".to_string());
     }
-    test::test_main(
-        &test_args,
-        tests,
-        Some(test::Options::new().display_output(display_doctest_warnings)),
-    );
+    test::test_main(&test_args, tests, None);
 }
 

The problem was that display_output(display_doctest_warnings) was overriding the argument passed on the command line.

[GuillaumeGomez]

You even provided the documentation alongside, it's great, thanks!

r=me once CI pass

[jyn514]

@bors r=GuillaumeGomez

[bors]

📌 Commit 7e4bf4b has been approved by GuillaumeGomez