Merged
Conversation
The tests checks some pretty-printer output, but pretty-printers are not embedded on windows-gnu
Don't treat unnormalized function arguments as well-formed Partial revert of rust-lang#88312 r? ``@pnkfelix`` cc ``@nikomatsakis``
…=wesleywiser Refactor EmitterWriter::emit_suggestion_default Makes progress towards rust-lang#89979 Split into 2 commits: * the first commit is purely a refactor and I verified that `./x.py test src/test/ui --stage 1` and `./x.py test src/test/rustdoc-ui --stage 1` continue to pass on this commit. * ~~the second commit removes the empty trailing line from diff style suggestions.~~ - I discovered an issue with this so its just the refactor now. r? diagnostics
…crum tests: Ignore `test/debuginfo/rc_arc.rs` on windows-gnu The tests checks some pretty-printer output, but pretty-printers are not embedded on windows-gnu. Regressed in rust-lang#85448.
CTFE: support assert_zero_valid and assert_uninit_valid This ensures the implementation of all three type-based assert_ intrinsics remains consistent in Miri. `assert_inhabited` recently got stabilized in rust-lang#90896 (meaning stable `const fn` can call it), so do the same with these other intrinsics. Cc ```@rust-lang/wg-const-eval```
Fix small typo Fix a typo in code commenting! `accross` -> `across`
…=lnicola ⬆️ rust-analyzer r? ```@ghost```
…=cjgillot Don't re-export `MirPass` `rust-analyzer` wants to use the `rustc_const_eval` one by default, which is weird. r? ``@cjgillot``
…=joshtriplett Add `drop_while` as doc alias to `Iterator::skip_while` `skip_while` is commonly referred to as `drop_while` in other languages (clojure/c++/haskell). This recently came up in [Zulip](https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/.E2.9C.94.20DropWhile/near/262203352) as well. This pull request adds 'drop_while' as a doc-alias for 'skip_while'. r? `@joshtriplett`
Member
Author
|
@bors r+ rollup=never p=8 |
Collaborator
|
📌 Commit 28176a4 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (1c02878): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Member
|
Probably due to #91243, but not very clear. |
Member
Author
Yeah, the original PR, #88312, has some large perf-regressions so it should be related, I missed that. @Mark-Simulacrum Should I run perf-check to make sure it? |
Member
|
I don't think it's worth it for an improvement, so I wouldn't spend time on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
test/debuginfo/rc_arc.rson windows-gnu #91317 (tests: Ignoretest/debuginfo/rc_arc.rson windows-gnu)MirPass#91368 (Don't re-exportMirPass)drop_whileas doc alias toIterator::skip_while#91383 (Adddrop_whileas doc alias toIterator::skip_while)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup