Merged
Conversation
And stop creating a fake `mod` item for the crate root when expanding a crate.
Cherry-picks llvm/llvm-project@ee88b8d and llvm/llvm-project@126e761 These patches to LLVM were added to help debug occasional errors that cause coverage reporting to fail. Prior to this patch, the only messaging was that the coverage data was malformed. Hopefully the improved messaging will help identify the root cause of these errors, when they arise, so we can make corrections to coverage output from Rust.
This was a regression from rust-lang#87337; the `panic_if_treat_err_as_bug` function only checked the number of hard errors, not the number of lint errors.
This unfortunately is still giving an unsilenceable overflow error :(
Add slice take methods Revival of rust-lang#62282 This PR adds the following slice methods: - `take` - `take_mut` - `take_first` - `take_first_mut` - `take_last` - `take_last_mut` r? `@LukasKalbertodt`
expand: Turn `ast::Crate` into a first class expansion target And stop creating a fake `mod` item for the crate root when expanding a crate, thus addressing FIXMEs left in rust-lang#82238, and making a step towards a proper support for crate-level macro attributes (cc rust-lang#54726). I haven't added token collection support for the whole crate in this PR, maybe later. r? `@Aaron1011`
…, r=tmandry Update LLVM with patches for better llvm-cov diagnostics Cherry-picks llvm/llvm-project@ee88b8d and llvm/llvm-project@126e761 These patches to LLVM were added to help debug occasional errors that cause coverage reporting to fail. Prior to this patch, the only messaging was that the coverage data was malformed. Hopefully the improved messaging will help identify the root cause of these errors, when they arise, so we can make corrections to coverage output from Rust. r? `@tmandry`
…-obk Include lint errors in error count for `-Ztreat-err-as-bug` This was a regression from rust-lang#87337; the `panic_if_treat_err_as_bug` function only checked the number of hard errors, not the number of lint errors. r? `@oli-obk`
Add tests for `normalize-docs` overflow errors `@b-naber` do you understand why using `try_normalize_erasing_regions` doesn't silence these cycle errors? Rustdoc isn't emitting them, rustc is aborting before returning an error, even though the function has `try_` in the name. cc rust-lang#82692, rust-lang#91255
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
|
📌 Commit 4ae75cf has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
apiraino
added
the
T-compiler
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Dec 1, 2021
Collaborator
|
Finished benchmarking commit (48a5999): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ast::Crateinto a first class expansion target #91313 (expand: Turnast::Crateinto a first class expansion target)-Ztreat-err-as-bug#91425 (Include lint errors in error count for-Ztreat-err-as-bug)normalize-docsoverflow errors #91430 (Add tests fornormalize-docsoverflow errors)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup