rustc_lint: Some early linting refactorings by petrochenkov · Pull Request #91526 · rust-lang/rust

petrochenkov · 2021-12-04T15:17:52Z

The first one removes and renames some fields and methods from EarlyContext.

The second one uses the set of registered tools (for tool attributes and tool lints) in a more centralized way.

The third one removes creation of a fake ast::Crate from fn pre_expansion_lint.
Pre-expansion linting is done with per-module granularity on freshly loaded modules, and it previously synthesized an ast::Crate to visit non-root modules, now they are visited as modules.
The node ID used for pre-expansion linting is also made more precise (the loaded module ID is used).

rust-highfive · 2021-12-04T15:17:55Z

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

rust-highfive · 2021-12-04T15:17:56Z

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

petrochenkov · 2021-12-06T00:16:49Z

The removal of the fake ast::Crate will be done in a different way, I need to tweak the first commit.

petrochenkov · 2021-12-07T12:34:10Z

Updated.

petrochenkov · 2021-12-28T08:42:00Z

Ping @estebank, it's been 3 weeks.

petrochenkov · 2022-01-20T05:19:19Z

Ping @estebank, it's been 6 weeks.

cjgillot

The pre-expansion lint infra is only used for the KeywordIdents lint. I'm wondering if such infra is really worth the complexity, or if we should just hardcode this lint and drop pre-expansion lints.

Either way, r=me after a rebase.

cjgillot · 2022-01-22T21:47:38Z

compiler/rustc_middle/src/ty/mod.rs

Pre-existing: do we use the span or the hygiene in the Ident, or can it simply be a FxHashSet<Symbol>?

It's used during name resolution, but in ResolverOutputs it could already be FxHashSet<Symbol>, I just didn't bother converting and used the same type everywhere.

petrochenkov · 2022-01-23T05:01:57Z

The pre-expansion lint infra is only used for the KeywordIdents lint. I'm wondering if such infra is really worth the complexity, or if we should just hardcode this lint and drop pre-expansion lints.

I'm also not sure how useful all of this is, but there are also a couple of lints in clippy using the same pre-expansion lint infra.

Use consistent function parameter order for early context construction and early linting Rename some functions to make it clear that they do not necessarily work on the whole crate

Add a trait generalizing over the crate root and freshly loaded modules instead This also makes node IDs used for pre-expansion linting more precise

petrochenkov · 2022-01-23T11:32:55Z

r? @cjgillot @bors r=cjgillot

bors · 2022-01-23T11:32:57Z

📌 Commit 67cccaf has been approved by cjgillot

…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#91526 (rustc_lint: Some early linting refactorings) - rust-lang#92555 (Implement RFC 3151: Scoped threads.) - rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags) - rust-lang#93219 (Add preliminary support for inline assembly for msp430.) - rust-lang#93226 (Normalize field access types during borrowck) - rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck) - rust-lang#93229 (Remove DiagnosticBuilder.quiet) - rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned estebank Dec 4, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2021

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2021

petrochenkov force-pushed the earlint branch from f0ae8d5 to 496c6a1 Compare December 7, 2021 12:30

petrochenkov changed the title ~~rustc_lint: Two early linting refactorings~~ rustc_lint: Three early linting refactorings Dec 7, 2021

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 7, 2021