Merged
Conversation
At first, you might think, "Why not just click through to the aliased type?" But, if a type alias instantiates all of the generic parameters of the aliased type, then it can show layout info even though the aliased type cannot (because we can't compute layout for generic types). So, I think it's useful to show layout info for type aliases. This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d (originally part of rust-lang#83501).
This commit does the following. - Expands on some of the things already mentioned in comments. - Describes the uniqueness assumption, which is critical but wasn't mentioned at all. - Rewrites `empty()` into a clearer form, as provided by Daniel Henry-Mantilla on Zulip. - Reorders things slightly so that more important things are higher up, and incidental things are lower down, which makes reading the code easier.
Co-authored-by: Joshua Nelson <github@jyn.dev>
Update library/core/src/iter/adapters/zip.rs Co-authored-by: r00ster <r00ster91@protonmail.com> Update library/core/src/iter/adapters/zip.rs Co-authored-by: r00ster <r00ster91@protonmail.com>
…y, r=lcnr Improve the readability of `List<T>`. This commit does the following. - Expands on some of the things already mentioned in comments. - Describes the uniqueness assumption, which is critical but wasn't mentioned at all. - Rewrites `empty()` into a clearer form, as provided by Daniel Henry-Mantilla on Zulip. - Reorders things slightly so that more important things are higher up, and incidental things are lower down, which makes reading the code easier. r? ````@lcnr````
Simplify collection of in-band lifetimes Split from rust-lang#91403 r? ````@oli-obk````
rustdoc: Show type layout for type aliases Fixes rust-lang#91265. At first, you might think, "Why not just click through to the aliased type?" But, if a type alias instantiates all of the generic parameters of the aliased type, then it can show layout info even though the aliased type cannot (because we can't compute layout for generic types). So, I think it's useful to show layout info for type aliases. This is a followup of 78d4b453ad2e19d44011b26fc55c949bff5dba3d (originally part of rust-lang#83501).
… r=Mark-Simulacrum Improve `std::iter::zip` example `println!` isn't great for doc comments / tests.
Add deprecation warning for --passes Issue rust-lang#91713 mentored by ```@jyn514```
…gisa give more help in the unaligned_references lint Cc rust-lang#82523 (comment) ``@kaisq``
… r=jyn514 Correct since attribute for `is_symlink` feature Follow-up from [89677](rust-lang#89677)
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit bb23d82 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (b8dc6aa): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
List<T>. #91617 (Improve the readability ofList<T>.)std::iter::zipexample #91711 (Improvestd::iter::zipexample)is_symlinkfeature #91782 (Correct since attribute foris_symlinkfeature)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup