Merged
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
See rust-lang#91867 for more information.
…, r=yaahc add BinaryHeap::try_reserve and BinaryHeap::try_reserve_exact `try_reserve` of many collections were stablized in rust-lang#87993 in 1.57.0. Add `try_reserve` for the rest collections such as `BinaryHeap` should be not controversial.
… r=davidtwco Suggest to specify a target triple when lang item is missing It is very common for newbies to embedded to hit this confusing error when forgetting to specify the target. Source: me googling this error many times. ## Possible changes * We could possibly restrict the note+help to only be included on eh_personality lang item if that helped reduce false positives, but its also possible doing so would just increase false negatives * Open to any suggestions on rewriting the messages * We could possibly remove the `.cargo/config` alternative to avoid the message getting too noisy but I think its valuable to have as its the correct approach for most embedded projects so that `cargo build` just works. r? rust-lang/diagnostics
…=yaahc Make `MaybeUninit::zeroed` `const` Tracking issue: rust-lang#91850 ```rust // core::mem impl<T> MaybeUninit<T> { pub const fn zeroed() -> MaybeUninit<T>; } ```
…g, r=Aaron1011 Use try_normalize_erasing_regions in RevealAllVisitor Fixes rust-lang#91745 Thanks to ``@Aaron1011`` for [pointing out the problem](rust-lang#91745 (comment)). r? ``@Aaron1011``
…val, r=oli-obk Remove `in_band_lifetimes` from `rustc_const_eval` See rust-lang#91867 for more information.
…le, r=dtolnay Fix HashStable implementation on InferTy HashStable impl forgot to hash the discriminant. Fixes rust-lang#91807
Remove `in_band_lifetimes` from `rustc_hir` rust-lang#91867
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 1dde0db has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced Dec 14, 2021
Merged
Collaborator
|
Finished benchmarking commit (404c847): comparison url. Summary: This change led to large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Contributor
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
MaybeUninit::zeroedconst#91851 (MakeMaybeUninit::zeroedconst)in_band_lifetimesfromrustc_const_eval#91887 (Removein_band_lifetimesfromrustc_const_eval)in_band_lifetimesfromrustc_hir#91893 (Removein_band_lifetimesfromrustc_hir)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup