Closed
Conversation
It's not emitted yet and most logic for it doesn't exist. This commit exists solely to make future changes smaller
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
jackh726
requested changes
Dec 17, 2021
Member
jackh726
left a comment
There was a problem hiding this comment.
Is there any documentation as to why this is needed? If there is, can you made add that here somewhere? If not, can you explain a bit?
| /// The arguments may be in any order, but one of them must be an opaque type. | ||
| /// The order and the boolean is used for resolving which opaque type defines | ||
| /// the other if both are opaque types and for diagnostics. | ||
| OpaqueType(Ty<'tcx>, Ty<'tcx>, bool), |
Member
There was a problem hiding this comment.
Why not just make the left be the opaque type being defined, and get rid of the bool?
Contributor
Author
There was a problem hiding this comment.
I think I tried that but got messed up diagnostics, but I'll try again
Contributor
Author
|
Closing in favour of merging #92007 in one go by allocating a pair-review session with niko and lcnr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not emitted yet and most logic for it doesn't exist.
This commit exists solely to make future changes smaller
r? @jackh726
this is one of the changes I mean in #92007 (comment)
Merging this will make further work easier to review and less bitrotty, but this PR has no logic changes to the actual execution of the compiler.