kmc-solid: Add std::sys::solid::fs::File::read_buf#92117
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 23, 2021
Merged
kmc-solid: Add std::sys::solid::fs::File::read_buf#92117bors merged 1 commit intorust-lang:masterfrom
std::sys::solid::fs::File::read_buf#92117bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
nrc
reviewed
Dec 20, 2021
Member
nrc
left a comment
There was a problem hiding this comment.
lgtm (I'm not familiar with the Solid API but the call matches the read impl so looks fine. The usage of ReadBuf lgtm).
Catching up with commit 3b263ce
e20e64a to
874514c
Compare
Member
|
Thanks! @bors r+ |
Collaborator
|
📌 Commit 874514c has been approved by |
Collaborator
|
⌛ Testing commit 874514c with merge c60cc9aeca09a5b201184e65deeb9c813daa32d1... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Contributor
|
@bors retry Windows test_interior_nul issue |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#88858 (Allow reverse iteration of lowercase'd/uppercase'd chars) - rust-lang#91544 (Fix duplicate derive clone suggestion) - rust-lang#92026 (Add some JSDoc comments to rustdoc JS) - rust-lang#92117 (kmc-solid: Add `std::sys::solid::fs::File::read_buf`) - rust-lang#92139 (Change Backtrace::enabled atomic from SeqCst to Relaxed) - rust-lang#92146 (Don't emit shared files when scraping examples from dependencies in Rustdoc) - rust-lang#92208 (Quote bat script command line) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
std::sys::solid::fs::File::read_bufto catch up with the changes introduced by #81156 and fix the*-kmc-solid_*Tier 3 targets..