[WIP] Remove ordering traits from HirId#92202
Closed
pierwill wants to merge 7 commits intorust-lang:masterfrom
Closed
[WIP] Remove ordering traits from HirId#92202pierwill wants to merge 7 commits intorust-lang:masterfrom
HirId#92202pierwill wants to merge 7 commits intorust-lang:masterfrom
Conversation
Implement `Ord`, `PartialOrd` for SpanData
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
HirIdHirId
Contributor
Author
|
@rustbot author |
Use indexmap where necessary to maintain ordering
1e8cecd to
f3f865e
Compare
pierwill
commented
Dec 22, 2021
Comment on lines
-2162
to
-2169
| // If that search fails, that is.. unusual. Maybe everything | ||
| // is in the same SCC or something. In that case, find what | ||
| // appears to be the most interesting point to report to the | ||
| // user via an even more ad-hoc guess. | ||
| categorized_path.sort_by(|p0, p1| p0.category.cmp(&p1.category)); | ||
| debug!("best_blame_constraint: sorted_path={:#?}", categorized_path); | ||
|
|
||
| categorized_path.remove(0) |
Contributor
Author
There was a problem hiding this comment.
Might be able to replace this logic via this fixme:
rust/compiler/rustc_borrowck/src/diagnostics/region_errors.rs
Lines 401 to 402 in f3f865e
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1e6c01d to
ab627aa
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rustbot author |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
indexmapwhereHirIds need ordering.Part of work on #90317.
(This is based on #90408. That PR should merge before this one.)