Make find_similar_impl_candidates a little fuzzier.#92223
Make find_similar_impl_candidates a little fuzzier.#92223BGR360 wants to merge 3 commits intorust-lang:masterfrom
find_similar_impl_candidates a little fuzzier.#92223Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
lcnr
left a comment
lcnr
left a comment
There was a problem hiding this comment.
it might be meaningful to also sort by whether the non-self parameters of the impls also match the searched ones.
would be nice to try this here if you're interested, otherwise we can also merge this as is.
i might not be available over the holidays, so you may have to wait a week until i can come back to you
There was a problem hiding this comment.
are there unwanted changes when using StripReferences::Yes here?
There was a problem hiding this comment.
that reasoning seems unclear to me 🤔 how does passing StripReferences::Yes prevent ourselves from being "too fuzzy"?
There was a problem hiding this comment.
i don't believe that this special case has a meaningful advantage over only using exact matches and fuzzy matches.
I would prefer removing this and removing the StripReferences function parameter from simplify_type. This should be the only place where it is currently used.
lcnr
added
S-waiting-on-author
JohnCSimon
added
S-waiting-on-author
|
Ping from triage: |
|
Sorry, been a lot of other stuff on my mind recently. I don't have immediate plans to continue on this, unless someone really wants this to get in. |
|
@lcnr I don't mind at all, thank you for carrying the torch for me! |
make `find_similar_impl_candidates` even fuzzier continues the good work of `@BGR360` in rust-lang#92223. I might have overshot a bit and we're now slightly too fuzzy 😅 with this we can now also simplify `simplify_type`, which is nice :3
5 participants
Resolves #92113
This is the initial draft, I'm curious for your thoughts. Still need to write ui tests for the arrays/slices case.
Let me know if anything is unclear; I stayed up far too late and am far too tired to document my decisions in more detail at this very moment 😁
r? @lcnr