Add an implicit Self: ~const Trait bound on default_method_body_is_const methods#92228
Closed
fee1-dead wants to merge 1 commit intorust-lang:masterfrom
Closed
Add an implicit Self: ~const Trait bound on default_method_body_is_const methods#92228fee1-dead wants to merge 1 commit intorust-lang:masterfrom
Self: ~const Trait bound on default_method_body_is_const methods#92228fee1-dead wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
oli-obk
requested changes
Dec 23, 2021
Contributor
oli-obk
left a comment
oli-obk
left a comment
There was a problem hiding this comment.
I think we need to start looking into improving diagnostics soon xD
| #[inline] | ||
| fn partial_cmp(&self, other: &$t) -> Option<Ordering> { | ||
| Some(self.cmp(other)) | ||
| Some(if *self < *other { Less } |
Contributor
There was a problem hiding this comment.
Please add a const hack comment here
This was referenced Dec 26, 2021
Collaborator
|
☔ The latest upstream changes (presumably #93956) made this pull request unmergeable. Please resolve the merge conflicts. |
oli-obk
added
S-waiting-on-author
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 25, 2022
Constify a few `(Partial)Ord` impls Only a few `impl`s are constified for now, as rust-lang#92257 has not landed in the bootstrap compiler yet and quite a few impls would need that fix. This unblocks rust-lang#92228, which unblocks marking iterator methods as `default_method_body_is_const`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 25, 2022
Constify a few `(Partial)Ord` impls Only a few `impl`s are constified for now, as rust-lang#92257 has not landed in the bootstrap compiler yet and quite a few impls would need that fix. This unblocks rust-lang#92228, which unblocks marking iterator methods as `default_method_body_is_const`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #92158
r? @oli-obk
Do not r+ before I prepare a
const_cmpPR.