Remove ordering traits from HirId#92233
Closed
pierwill wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
@rustbot author |
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
b294878 to
506d54b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1082ace to
81dec4b
Compare
HirIdHirId
Contributor
Author
|
r? @cjgillot |
Contributor
Author
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
cjgillot
reviewed
Dec 26, 2021
5 tasks
BGR360
reviewed
Dec 29, 2021
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #85321) made this pull request unmergeable. Please resolve the merge conflicts. |
7747530 to
491edf3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a043bed to
b05c0b5
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #96082) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@pierwill can you address the CI failure? thanks |
Rm Ord from LintExpectationId Edit ToStableHashKey impl Impl Partialord for Level using discriminant
b05c0b5 to
076fc29
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☔ The latest upstream changes (presumably #99334) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Closing this as inactive. Feel free to reöpen or preferably create a new pull request |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 2, 2025
…r-errors impl !PartialOrd for HirId revive of rust-lang#92233 Another checkbox of rust-lang#90317, another small step in making incremental less likely to die in horrible ways
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 3, 2025
…r-errors impl !PartialOrd for HirId revive of rust-lang#92233 Another checkbox of rust-lang#90317, another small step in making incremental less likely to die in horrible ways
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 3, 2025
…r-errors impl !PartialOrd for HirId revive of rust-lang#92233 Another checkbox of rust-lang#90317, another small step in making incremental less likely to die in horrible ways
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 4, 2025
Rollup merge of rust-lang#138610 - oli-obk:no-sort-hir-ids, r=compiler-errors impl !PartialOrd for HirId revive of rust-lang#92233 Another checkbox of rust-lang#90317, another small step in making incremental less likely to die in horrible ways
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 17, 2025
impl !PartialOrd for HirId revive of rust-lang/rust#92233 Another checkbox of rust-lang/rust#90317, another small step in making incremental less likely to die in horrible ways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #90317.