Suggest while let x = y when encountering while x = y#92402
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 3, 2022
pr2502:while-let-typo
Merged
Suggest while let x = y when encountering while x = y#92402bors merged 1 commit intorust-lang:masterfrom pr2502:while-let-typo
bors merged 1 commit intorust-lang:masterfrom
pr2502:while-let-typo
Conversation
Extends #75931 to also detect where the `let` might be missing from `while let` expressions.
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
Member
|
Thanks for the PR, @pr2502! r? rust-lang/diagnostics |
Contributor
|
Nice! @bors r+ rollup |
Collaborator
|
📌 Commit 874cd08 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 3, 2022
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#90102 (Remove `NullOp::Box`) - rust-lang#92011 (Use field span in `rustc_macros` when emitting decode call) - rust-lang#92402 (Suggest while let x = y when encountering while x = y) - rust-lang#92409 (Couple of libtest cleanups) - rust-lang#92418 (Fix spacing in pretty printed PatKind::Struct with no fields) - rust-lang#92444 (Consolidate Result's and Option's methods into fewer impl blocks) Failed merges: - rust-lang#92483 (Stabilize `result_cloned` and `result_copied`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #75931 to also detect where the
letmight be missing fromwhile letexpressions.