add #[must_use] to functions of slice and its iterators.#92853
Closed
jendrikw wants to merge 0 commit intorust-lang:masterfrom
jendrikw:slice-must-use
Closed
add #[must_use] to functions of slice and its iterators.#92853jendrikw wants to merge 0 commit intorust-lang:masterfrom jendrikw:slice-must-use
jendrikw wants to merge 0 commit intorust-lang:masterfrom
jendrikw:slice-must-use
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnCSimon
added
S-waiting-on-review
Contributor
|
@rustbot label: +T-libs-api, -T-compiler |
rustbot
added
T-libs-api
Member
|
@bors r+ rollup=iffy (Marking rollup=iffy because changes like this often end up going through a couple of rounds of CI due to unexpected call-sites that don't get updated.) |
Collaborator
|
📌 Commit cdf22c3 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
Collaborator
|
⌛ Testing commit cdf22c3 with merge ea25263a5702364a747107c34defc33505d67b2e... |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 4, 2022
…lett add #[must_use] to functions of slice and its iterators. See rust-lang#89692.
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #94628) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
rebased. |
Collaborator
|
☔ The latest upstream changes (presumably #94802) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Author
|
Sorry I messed up my branch. Re-opened at #95274. |
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 26, 2022
add #[must_use] to functions of slice and its iterators. Continuation of rust-lang#92853. Tracking issue: rust-lang#89692.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2022
add #[must_use] to functions of slice and its iterators. Continuation of rust-lang#92853. Tracking issue: rust-lang#89692.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 7, 2022
add #[must_use] to functions of slice and its iterators. Continuation of rust-lang#92853. Tracking issue: rust-lang#89692.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #89692.