Do not fail evaluation in const blocks#92892
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 15, 2022
Merged
Conversation
rustbot
added
the
T-compiler
Contributor
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
nbdd0121
reviewed
Jan 14, 2022
Member
nbdd0121
left a comment
nbdd0121
left a comment
There was a problem hiding this comment.
The fix LGTM but I think this needs a test.
Member
|
r? @fee1-dead @rustbot author: please add a ui test for the issue, in |
Collaborator
|
Error: Parsing shortcut command in comment failed: ...'bot author' | error: expected end of command at >| ': please a'... Please let |
fee1-dead
added
S-waiting-on-author
compiler-errors
force-pushed
the
const-param-env-for-const-block
branch
from
7ced82c to
b9a3c32
Compare
Contributor
Author
|
@rustbot ready Hah, sorry, added a test last night then forgot to commit it. |
rustbot
added
S-waiting-on-review
fee1-dead
approved these changes
Jan 15, 2022
Member
|
@bors r+ rollup |
Collaborator
|
📌 Commit b9a3c32 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92747 (Simplification of BigNum::bit_length) - rust-lang#92767 (Use the new language identifier for Rust in the PDB debug format) - rust-lang#92775 (Inline std::os::unix::ffi::OsStringExt methods) - rust-lang#92863 (Remove `&mut` from `io::read_to_string` signature) - rust-lang#92865 (Ignore static lifetimes for GATs outlives lint) - rust-lang#92873 (Generate more precise generator names) - rust-lang#92879 (Add Sync bound to allocator parameter in vec::IntoIter) - rust-lang#92892 (Do not fail evaluation in const blocks) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2022
Add `~const` bound test for negative impls Resolves rust-lang#92114 which has been fixed in rust-lang#92892.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluate const blocks with a const param-env, so we properly check
~consttrait bounds.Fixes #92713
(I will fix the poor diagnostics in #92713 and #92712 in a separate PR)
cc @nbdd0121 who wrote the code this PR touches in #89561