Track inlined items and merge their docstrings when creating clean attributes

[lambinoo]

Fixes #84619

[rust-highfive]

Some changes occurred in clean/types.rs.

cc @camelid

[rust-highfive]

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

[camelid]

I think this will duplicate docstrings for non-local inlined items. I also think isn't the right approach. Can you try #84619 (comment)?

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustdoc v0.0.0 (/checkout/src/librustdoc)
error[E0308]: mismatched types
   --> src/librustdoc/clean/types.rs:453:52
    |
453 |                 let other_attrs = cx.tcx.get_attrs(inlined_id).clean(cx);
    |                                                    ^^^^^^^^^^ expected struct `rustc_span::def_id::DefId`, found struct `LocalDefId`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `rustdoc` due to previous error
Build completed unsuccessfully in 0:03:06

[lambinoo]

Update: I think I found a better way just by getting a better understanding of Rustdoc! I'll try to get some more work done during the following week.
@camelid I did add a tracing::warn at the beginning when I was trying to understand when it was being called. With the example in the issue, it never gets called.

I think that's the call path that's relevant:
try_inline < clean_use_statement < clean_maybe_renamed_item for each DocModule::items

DocModule::items itself gets filled by RustdocVisitor::visit_item(). When it comes to use statements, it only adds them to the stack when they are not being inlined themselves by maybe_inline_local.

That's the reason I took this path of keeping track of every "inlined" items.

[bors]

☔ The latest upstream changes (presumably #96214) made this pull request unmergeable. Please resolve the merge conflicts.

[Dylan-DPC]

@lambinoo any updates on this?

[Dylan-DPC]

Closing this as inactive