Merged
Conversation
readdir() is preferred over readdir_r() on Linux and many other platforms because it more gracefully supports long file names. Both glibc and musl (and presumably all other Linux libc implementations) guarantee that readdir() is thread-safe as long as a single DIR* is not accessed concurrently, which is enough to make a readdir()-based implementation of ReadDir safe. This implementation is already used for some other OSes including Fuchsia, Redox, and Solaris. See rust-lang#40021 for more details. Fixes rust-lang#86649. Fixes rust-lang#34668.
Bionic also guarantees that readdir() is thread-safe enough.
Co-authored-by: Noah Lev <camelidcamel@gmail.com>
…g exponent and mantissa
…agisa Improve Duration::try_from_secs_f32/64 accuracy by directly processing exponent and mantissa Closes: rust-lang#90225 The methods now implement direct processing of exponent and mantissa, which should result in the best possible conversion accuracy (modulo truncation, i.e. float value of 19.995 ns will be represented as 19 ns).
…lections-examples, r=yaahc Replace iterator-based construction of collections by `Into<T>` Just a few quality of life improvements in the doc examples. I also removed some `Vec`s in favor of arrays.
…lbini add OpenBSD platform-support page It mentions x86_64, i686, aarch64 and sparc64 which are actively maintained and used on OpenBSD (binaries provided by standard package distribution on OpenBSD). I volontary kept `powerpc-unknown-openbsd` unmentioned as it was added by `@Yn0ga` in rust-lang#82733, and I am unaware if it is functional or not (I doubt as I added libc support only few days ago, and std `c_char` signess was wrong). `@Yn0ga` maybe you comment on your `powerpc-unknown-openbsd` usage ?
Add x86_64-pc-windows-msvc linker-plugin-lto instructions I had some trouble getting cross language LTO working for this target, in part because the very few links of documentation I could find were linux-centric and because of a few very specific errors I ran into. I'm not sure if this is the correct place to document this, but this is one of the first links I found when looking for documentation so it might be the best place for it.
…oli-obk Improve selection errors for `~const` trait bounds
…shtriplett fs: Use readdir() instead of readdir_r() on Linux and Android See rust-lang#40021 for more details. Fixes rust-lang#86649. Fixes rust-lang#34668.
…otriddle Update minifier crate version to 0.0.42 Some issues on the CSS minification. r? `@notriddle`
rustbot
added
T-compiler
Member
Author
|
@bors r+ rollup=never p=7 |
Collaborator
|
📌 Commit 4276626 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jan 27, 2022
Tested on commit rust-lang/rust@009c1d0. Direct link to PR: <rust-lang/rust#93352> 💔 miri on linux: test-pass → test-fail (cc @oli-obk @RalfJung @eddyb).
This was referenced Jan 27, 2022
Collaborator
|
Finished benchmarking commit (009c1d0): comparison url. Summary: This benchmark run did not return any relevant results. 10 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Into<T>#91861 (Replace iterator-based construction of collections byInto<T>)~consttrait bounds #92256 (Improve selection errors for~consttrait bounds)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup