Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
|
Looks good to me overall, thanks! Your PR seems to done a bit more than what the test you updated seems to check. Can you add more checks please? Also cc @camelid in case you want to take a second look. :) |
camelid
left a comment
There was a problem hiding this comment.
Please also add some tests of the expected behavior, e.g. for skipping the ~const part or excluding ~const Drop.
d6f64c8 to
79f2180
Compare
|
I have addressed the comments and added a test for the display. |
|
Looks good to me, thanks! Waiting for @camelid now. ;) |
|
Sorry, I don't have time to review the code. Could you summarize the current version of the changes in this PR? |
|
|
It also hides const generic wf bounds: [T; SIZE]: (no trait) will be hidden |
|
Sounds reasonable. Can you add something to the tracking issue for |
|
Sure, I'll update the issue when I have access to a computer. As for |
|
@camelid: Did you want to review this PR when you have time again? Or do you think it is fine as is? |
|
The changes sound good to me. I haven't reviewed the code, but as long as Guillaume has, I don't think I need to. It'd be good to update the PR description with your extended description of the changes, but other than that I think this should be good. |
|
Please ping me once the PR description has been updated so I can approve it. |
|
@GuillaumeGomez: I have updated the PR description. |
|
Thanks! @bors: r= |
|
📌 Commit 484936b has been approved by `` |
|
Second time will work better... @bors r+ |
|
📌 Commit 484936b has been approved by |
…askrgr Rollup of 3 pull requests Successful merges: - rust-lang#93412 (Improve rustdoc const bounds) - rust-lang#94617 (Update `itertools`) - rust-lang#94669 (Update -Z unpretty error message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
~constin trait bounds, because it currently means nothing for stable users, and because we still haven't decided on the final syntax yet.DropAND it is~const, i.e.~const Dropbounds because it has no effect on stable users as well.wherestatement where it consists of~const Dropbounds (so it doesn't displaystruct Foo<T>() where ;like that), bounds that have no trait e.g.where [T; N+1]: ;are also hidden.Cherry-picked from #92433.